xournalpp-1.2.3-windows failed to set gui language to zh about xournalpp HOT 20 OPEN

I tested it, and it worked for me.

Still having this problem on my computer, I recorded the video. I don't know what caused it.

from xournalpp.

On Windows 10 (version 22H2 19045.4170, System Code Pages: 936), when the language is set to Chinese (zh), the menus for version v1.2.3 are not translated into Chinese. Only the screenshots from the previous comment show translation for version v1.2.3+dev-nightly.20240421.

I also installed versions v1.2.3 and v1.2.3+dev-nightly.20240421 on another Win11 computer (version 21H2 22000.1817, System Code Page: 936). When the language is set to Chinese (zh), some menus for version v1.2.3 are translated into Chinese, while almost all menus for version v1.2.3+dev-nightly.20240421 are in Chinese. Please refer to the video I recorded.

I believe the behavior on Win11 is normal, while the behavior on Win10 is abnormal.

from xournalpp.

I tested it, and it worked for me, but it seems like, that the translation is not nearly complete. Since we depend on the community here, I please you to do some translations on Crowdin: https://crowdin.com/project/xournalpp/zh.

from xournalpp.

Seems like, setting the locale works, but it has no effect, probably something wrong with gettext. What's the content of C:\Program Files\Xournal++\share\locale\zh\LC_MESSAGES, is there a xournalpp.mo file?

from xournalpp.

Yes, there's a xournalpp.mo file.
xournalpp.zip

from xournalpp.

Can you try this? https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page

from xournalpp.

Can you also tell me the full path of the xournalpp.mo file? It may be, that we have an issue with utf8 / conversion of paths. I may have tracked it down to PathUtil.cpp:180 auto Util::getGettextFilepath(const char* locale_dir) -> fs::path which incorrectly mixes utf8 and system path encoding.

from xournalpp.

Can you try this? https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page

I tried this and the problem is still there.

Can you also tell me the full path of the xournalpp.mo file?

I installed it automatically using the installer. The path is
C:\Program Files\Xournal++\share\locale\zh\LC_MESSAGES\xournalpp.mo

from xournalpp.

I installed the following version into C:\Program Files\Xournal++,
https://github.com/xournalpp/xournalpp/releases/download/nightly/xournalpp-1.2.3+dev-nightly.20240421-windows.zip

and when I set the language to zh and restarted, only the two places in the picture below were translated into Chinese. This might be helpful in resolving this issue.

from xournalpp.

Most likely the reason for this is, that there does not exist any translation for this. You could help out, by translating those on crowdin. I can't speak Chinese and we also don't have any one in the core team which does.

from xournalpp.

Something similar happens with the German locale (Windows, Xournal++ v. 1.2.3 as well). As you can see, some menu entries are in German while some are in English.

from xournalpp.

Something similar happens with the German locale (Windows, Xournal++ v. 1.2.3 as well). As you can see, some menu entries are in German while some are in English.
Image

The reason for this is, that there is just no translation for this in the locale file.
But @saxyx new issue is, that both releases show different output on windows 10 and windows 11.

from xournalpp.

@rolandlo can you update the translations for release 1.2?

from xournalpp.

@rolandlo can you update the translations for release 1.2?

Hmm, not sure if that makes sense. The translations are always made for master as you can see from https://crowdin.com/project/xournalpp/sources/files, so if we merge them into release 1.2, it may not work very well. We have only updated translations for master (and never for minor releases).

from xournalpp.

Mhh, can we add also translations from the last minor release?
Another solution would be, to merge translations of the latest 2/3 (with xpp2.0 in mind) versions?

from xournalpp.

I'm not sure if we understand each other correctly. What I called "minor release" are versions 1.2.1, 1.2.2, 1.2.3 and the like. Version 1.2.3 runs with the translations from 1.2.0 (as do 1.2.1 and 1.2.2) and the current translations on Crowdin are for master. Are you saying we should just use the translations from master (maybe from a previous commit) and apply them to the release-1.2 branch? Normally we just merge translations into master every 2-3 months and for sure before the 1.3.0 release.

from xournalpp.

x.x.Y are patch releases, major is Y.x.x .
What I mean is, to either

• merge the po from master and the minor branch together, so that the translations will work for both. This might increase translation files a bit (~5%).
• or, add an additional translation branch in crowdin
• or, just use translations from master.

from xournalpp.

I'd vote for either 1. or 2., with a preference for 2. (depending on how easy it is to configure)

from xournalpp.

I'd vote for either 1. or 2., with a preference for 2. (depending on how easy it is to configure)

Same. But I don't know how to configure that. Also @LittleHuba wrote the bot to do that for the master branch.

from xournalpp.

I would also go with 2. To configure that in Crowdin, it looks like one can add the branch via the "New Version branch" dropdown next to the "New folder" button.

from xournalpp.