Git Product home page Git Product logo

Comments (8)

xou816 avatar xou816 commented on September 1, 2024 2

Ahah there's a lot to go through here, but I appreciate the feedback!!

It would probably be easier to open a couple dedicated issues to track progress/discussion for each suggestion.

But just to answer some of your points:

  • I love that login dialog mockup!! almost itching to start working on it
  • sidebar: I agree with most of your points! dynamically ordering playlists might be its own issue entirely (I've always wanted to have some kind of history implemented, @Diegovsky too I think, but this might take more work than the other points). Also looking forward to what libadwaita is going to offer! Leaflets have been a bit troublesome to get right for me at least (I still can't figure out stuff like #386)
  • search: it's one of the screens I haven't touched since its inception! I intend to work on it next actually, and I'd love some input from you or @jannuary on the design (I'll explain below)
  • light dark/theme: I don't think there's an issue with keeping the option there, but maybe we should change the default value to follow system theme?
  • various alignement/font issues: I am sort of aware of them (and there are more, if you switch to the narrow screen layout some things look pretty bad), these could definitely could be good first issues, I've been too lazy to address them myself :P

As for TWIG (great banner by the way thanks!) I think I'm fine without the extra attention for now :) Looks like there's already a decent chunk of work ahead


About search: I want to rework it to display a few more results, including individual tracks (finally!) and playlists.

Keeping the constraints of having a narrow screen in mind, the results would probably be displayed in a list with a similar style to what we have for songs at the moment, with small differences in the row layout depending on the result type (album, artist, etc)

Example layout (Inkscape is not my forte):

(headerbar with entry)
-----------------------------
[item 1 = some artist]
[item 2 = some album]
[item 3 = some other album]
9item 4 = some song]

but I'd like to allow the search results to be refined by selecting an artist. I imagine the layout of an artist result to be something like

| (picture) (artist name) (filter or pin icon btn) (forward arrow icon btn) |

where the last button would just open the artist page (which I also need to redesign eventually).

The first button, however, would move the artist at the top of the page and give it a distinctive visual style:

(headerbar with entry)
-----------------------------
[item 1 = "pinned"/"filtered" artist]

(space/separator?)

[item 2 = some album]
[item 3 = some other album]
9item 4 = some song]

and the results would be updated to match the pinned artist.

This is not very standard -- I understand this kind of feature usually involves a dropdown next to the search entry, and then "pills" in the entry itself, but that would use up a lot of space, and I think this kind of "iterative" search experience could be nice.

Does that make sense?

from spot.

ArberTu474 avatar ArberTu474 commented on September 1, 2024

Sorry, not something related to this issue directly. I wanted to know how did you design these gtk mockups? Did you code them or there is a Figma design kit for gtk?

from spot.

bragefuglseth avatar bragefuglseth commented on September 1, 2024

Sorry, not something related to this issue directly. I wanted to know how did you design these gtk mockups? Did you code them or there is a Figma design kit for gtk?

GNOME uses Inkscape for mockups. They are SVGs. The Mockup Resources repository contains SVG assets that can be copied and pasted as needed. It's also possible to use things other designers have drawn in existing mockups. There are no Figma assets AFAIK, but SVG allows for a lot of flexibility 😄

from spot.

bragefuglseth avatar bragefuglseth commented on September 1, 2024

It would probably be easier to open a couple dedicated issues to track progress/discussion for each suggestion.

My thought process was that you probably have a lot of other priorities/concerns for the app right now, and thus I wanted to present these as potential ideas for later on instead of concise suggestions you have to address right now 🙂

The login redesign utilizes some new Libadwaita widgets, so you'll have to update to the latest Libadwaita first if you haven't already.

As for the search stuff, it looks interesting! I'll mock it up! 😀

from spot.

bragefuglseth avatar bragefuglseth commented on September 1, 2024

I'll open separate issues for the main points.

from spot.

bragefuglseth avatar bragefuglseth commented on September 1, 2024

About search: I want to rework it to display a few more results, including individual tracks (finally!) and playlists.

I have made an initial mockup in #616 now, let me know if you want anything changed :)

from spot.

bragefuglseth avatar bragefuglseth commented on September 1, 2024

Closing this as I have separated out most of my points into different issues.

from spot.

jannuary avatar jannuary commented on September 1, 2024

Re: light/dark toggle — I'm fine with dropping it and using light by default.

from spot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.