Git Product home page Git Product logo

Comments (25)

Xonshiz avatar Xonshiz commented on May 29, 2024 3

In all honesty, I don't really want to write an extra module for just one website. I MIGHT come up with some other file naming pattern that will not cause conflicts.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024 1

Here is the repo

Download link in Wiki.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024 1

Let me look into the the download location problem.

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

No, the structure will probably remain same as to avoid any file name conflict. Readcomiconline.to isn't the only website this script supports. Manga and other comic website don't follow the "Issue" thing.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

Atleast give an option.....

No problem. Great work by the way.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

@Xonshiz I have made a GUI for the binary.
I have attached the file.
You just have to extract the file and place it in the folder containing comic_dl.exe

GUI.zip

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

It's great that you made a GUI, but I don't want to run an .exe from untrusted source on my system atm. I'll look into it later on.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

Okay

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

By the way how to prove it doesn't have any virus or malware.

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

why don't you make a repo for it and share that? That'd be better.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

Okay

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

Hey, just tested it! It's amazing! It could do some changes with the graphics. Hmmm... I was working on a GUI for Comic_dl as well.. in C#. There seems to be an issue with your version. When I selected a "download location", it froze the UI and mentioned that it had an issue. But, it downloaded just fine without giving any download location.

Amazing work!

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

There's a problem with your GUI. It freezes the UI, while downloading. Maybe you should make an async method and put an await to to... you know, wait for the thread to complete its work without freezing the UI.

I'm a little busy with some work this month, I'll try to finish up the UI I made by the end of this month.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

No I have disabled the GUI when It downloads so that you would not start while the program is running.
Only after downloading can you give the arguments again.

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

Ohhh, I see. Nice, I like it. The UI I had in mind is a little bit different. I have a test broken project lying around somewhere on my system... I'll have to re-build it and fix things accordingly.

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

Just a rule of thumb, when you post your project/share it, make sure you clean the build.

Build --> Clean Solution

from comic-dl.

jaxxa avatar jaxxa commented on May 29, 2024

Or even better setup a .gitignore file.

I have not looked at it yet as I am not at home but a GUI sounds nice.
I made a small program for personal use that renames the images and packaging into .cbz files to work around #30
I can look into integrating that into your GUI if you like.

https://github.com/jaxxa/ComicCreator

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

Okay
But I have a problem.
My exam will start and I will be unable to code during that period.
But as soon as they get over I will work on it.

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

What is wrong with this command;
comic_dl -dd "C:\Users\Baidyanath Kundu\Documents\Dead\" -i "http://readcomiconline.to/Comic/Deadpool-2016"

I am getting error:

I need an Input URL to download from.

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

command looks fine.. try with verbose

from comic-dl.

sudo-panda avatar sudo-panda commented on May 29, 2024

DEBUG: Arguments Provided : Namespace(convert='None', download_directory=['C:\Users\Baidyanath Kundu\Documents\Dead" -i http://readcomiconline.to/Comic/Deadpool-2016'], input=None, keep='True', range='All', sorting=None, verbose=True, version=False)
DEBUG: Operating System : Windows - 10 - 10.0.15063
DEBUG: Python Version : 2.7.13 (32bit)

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

Try this :

comic_dl -i "http://readcomiconline.to/Comic/Deadpool-2016" -dd "C:\Users\Baidyanath Kundu\Documents\Dead\"

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

Oh wait, seems like the arguments are being parsed in a wrong way.
download_directory=['C:\Users\Baidyanath Kundu\Documents\Dead" -i http://readcomiconline.to/Comic/Deadpool-2016'

-i is being taken into -dd

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

I checked it on my end as well.This is a BUG. Could you please open a new issue with this?

from comic-dl.

Xonshiz avatar Xonshiz commented on May 29, 2024

This should be fixed now.

from comic-dl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.