API change proposal about argus HOT 6 CLOSED

So id is a string that matches the following regex: [a-zA-Z0-9]{1,64}

(1 to 64 ASCII alphanumeric characters)

Right?

from argus.

There is no reason why Argus can't enforce the primary identifier to be a true UUID. Even if we choose to not use an UUID, Argus should still place constraints on what a valid value should look like (SHA256, MD5, etc).

from argus.

True. What does each option give us?
One route is to switch back to the ID field name and place the constraint that it must be a SHA256 checksum.

from argus.

Let's change the field name to id, but have strict enforcement that this field must be a 64 character long alpha-numeric string. We can then suggest using SHA256 to generate this string.

from argus.

That looks right to me.

from argus.

Additional info: The webhooks library was sending a base64 URL encoding of the digest https://github.com/xmidt-org/webpa-common/blob/main/xwebhook/service.go#L89
If we add this, it should be easy to just send the digest itself.

from argus.