Comments (4)
Current status: #43
from rav1e.
@mbebenita , @smarter
After one year later, "cargo fmt" still not move some code style from nightly to stable.
Currently, many codes do not have the right style.
How about we accept reality, use stable "cargo fmt" and enforce it in pre-commit hook and travis?
#1259 will enforce this
thanks
from rav1e.
The main sticking point is fn_args_layout, which is still not stable. We can either live with the default for this option or continue to not enforce rustfmt.
from rav1e.
Currently most of the options we use are stable on the beta branch of rustfmt
.
There are three left-over unstable options:
comment_width
: this one actually has no effect because we don't setwrap_comments
;match_arm_blocks
: I'd argue it doesn't really make much difference and can be dropped;ignore
: this can be dropped with the reformat.
I'll make a PR to drop these options (and also a couple of other ones that are set to the default values). After that, there are two options:
- run and set up the beta
rustfmt
right before the crate release; - wait until the current beta
rustfmt
reaches stable (15th Aug 2019).
from rav1e.
Related Issues (20)
- Merge dav1d v1.2.0 x86 and ARM assembly
- Advanced commands do not seem to work HOT 1
- realtime encode HOT 8
- Package rav1e-devcontainer is private HOT 2
- Assertion failed at src\encoder.rs:2242:3 HOT 4
- Crash on encode fuzztest HOT 5
- Cannot encode large images due to 983b954b6585c863e84fce82f31be2e152d28ed7
- Cannot build on macOS with arm clips HOT 1
- Precompiled binaries fail to state they target musl on linux HOT 3
- sad_32x32 and 64x64 AVX2 has poor cache locality HOT 3
- Update rustc HOT 1
- Read of uninitialized data HOT 2
- call_inverse_func incorrectly shortens width HOT 2
- Ubuntu lunar dav1d-tests-arm64 job is defunct HOT 1
- key_frame_interval capi option inconsistently named with cli
- How is SizeClass1D::X4 initializing row_coeffs? HOT 1
- master branch has older version number than crates.io HOT 1
- crates.io release? HOT 3
- NASM warnings about empty macro parameters
- Can't build v0.7.0 on Alpine Linux HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rav1e.