Git Product home page Git Product logo

Comments (4)

smarter avatar smarter commented on June 12, 2024

Current status: #43

from rav1e.

xuguangxin avatar xuguangxin commented on June 12, 2024

@mbebenita , @smarter
After one year later, "cargo fmt" still not move some code style from nightly to stable.
Currently, many codes do not have the right style.
How about we accept reality, use stable "cargo fmt" and enforce it in pre-commit hook and travis?
#1259 will enforce this

thanks

from rav1e.

tdaede avatar tdaede commented on June 12, 2024

The main sticking point is fn_args_layout, which is still not stable. We can either live with the default for this option or continue to not enforce rustfmt.

from rav1e.

YaLTeR avatar YaLTeR commented on June 12, 2024

Currently most of the options we use are stable on the beta branch of rustfmt.

There are three left-over unstable options:

  • comment_width: this one actually has no effect because we don't set wrap_comments;
  • match_arm_blocks: I'd argue it doesn't really make much difference and can be dropped;
  • ignore: this can be dropped with the reformat.

I'll make a PR to drop these options (and also a couple of other ones that are set to the default values). After that, there are two options:

  • run and set up the beta rustfmt right before the crate release;
  • wait until the current beta rustfmt reaches stable (15th Aug 2019).

from rav1e.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.