Comments (1)
serj-lotutovici
commented on July 20, 2024
Hey @bstobbe! First of all thank you for your feedback. The problem with XingOAuthCallback is that it misleads developers to an assumption, that the call to onActivityResult() is not needed, when in reality it's the only way to get the response (the activity that displays the logic form returns the response in it's result Bundle). This also allows us to test the result logic in a more straight forward way.
For your situation, I can suggest the following:
- either create a base activity, where you implement the XING authentification logic + the response and error handling, and ensure that every activity that has a XING login inherits form it.
- or create a handler class that is used as a delegate for the XING auth handling and use it in every activity that requires it. There you can use your own callbacks, which will give you more control. But still you will have to call XingOAuth#onActivityResult().
from xing-android-sdk.
Related Issues (20)
- Consider AutoValue for api client models. HOT 4
- IllegalArgumentException when using callbackUrl in XingOAuth.Builder HOT 12
- Drop XingOAuthCallback? HOT 2
- Create fields companion class from all data models. HOT 1
- Release 2.0.0 preparation HOT 2
- XingApiClient requests caching to be optional HOT 1
- Logout HOT 4
- when setting xing callback uri it throws invalidarguementexception HOT 4
- Separate CallSpec tests by scope.
- Allow callers to set an OkHttpClient.
- Change apiEndpoint HOT 4
- Consider integration with CodeCov for better coverage reporting in PRs
- Improvement - Readme update
- Fall back to String if error returned from api client is not matching HttpError
- Update OkHttp dependency
- Remove Okio dependency
- OAuth credentials HOT 2
- Introduce newBuilder
- Where is the iOS sdk?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xing-android-sdk.