Git Product home page Git Product logo

Comments (7)

keryell avatar keryell commented on July 21, 2024

I understand your motivation.
But from the bigger picture point of view, this part just™ works™, which is an undeniable quality. :-)
Boost is widely used world-wide and not the worse thing to use or to package.
At the end it might just add to the NIH syndrome which is already a problem.
If you have some spare brain cycles and extra budget, there are other few issues to fix I can see in my priority list: just make it to compile #7806, cleaning up the code (you can dive into https://github.com/Xilinx/XRT/tree/master/src/runtime_src/core/pcie/emulation), improve Vitis and ROCm packaging... :-)
But anyway, just my personal feeling.

from xrt.

stsoe avatar stsoe commented on July 21, 2024

@newling This is work-in-progress. We are removing boost dependencies as we type.

I think we are very close to have no link time dependencies left in the xrt shared libraries, but we have a few inline boost library dependencies some of which can be replaced as we move to use more modern c++. However boost property_tree is the more difficult one. What is the problem with the few inline libraries being used?

As for linking with boost, the stand-alone tools part of XRT do bring in boost library dependencies, but that is not really a problem related to IREE's use of XRT.

from xrt.

stsoe avatar stsoe commented on July 21, 2024

@keryell Your ubuntu23.10 issue is assigned and being fixed now.

from xrt.

newling avatar newling commented on July 21, 2024

@stsoe it is good to hear that you're close to having no link time dependencies to boost for the xrt libraries. Header only dependencies are much better (I didn't realize property_tree was header only).

from xrt.

newling avatar newling commented on July 21, 2024

@stsoe do you have a rough idea of when XRT will be link time dep free? Weeks/months?

from xrt.

stsoe avatar stsoe commented on July 21, 2024

Hi @newling. I don't see any boost link time dependencies in the shared libraries even today. So this was implemented with the removal of boost::filesystem within the last month or so.

from xrt.

newling avatar newling commented on July 21, 2024

Super, thanks Soren.

from xrt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.