Git Product home page Git Product logo

Comments (4)

Giuseppe5 avatar Giuseppe5 commented on June 3, 2024 1

When dealing with squeeze/unsqueeze, we also have to handle the shapes of scale factors and zero points.

Related to #728

from brevitas.

sanjay-rb avatar sanjay-rb commented on June 3, 2024

Hi @nickfraser ,

You wanted to add squeeze / unsqueeze operations in quant_invariant_handler function right ?

from brevitas.

ScXfjiang avatar ScXfjiang commented on June 3, 2024

For per-channel quantization

Squeeze/Unsqueeze OP is more like Permute OP, where we can find easy ways to modify the QuantTensor to keep those OPs affine quantization invariant. In the case of Squeeze/Unsqueeze OP, all we need to do is squeeze/unsqueeze the scale and zero point tensor accordingly.

However, OPs mentioned in #728 (reshape, flatten) are non-trivial. There are no trivial ways to modify the QuantTensor to keep those OPs affine quantization invariant. Recalculation of scale and zero point is inevitable. We may need to dequantize --> reshape/flatten --> requantize to bypass this problem, at the price of precision loss.

It looks like PyTorch doesn't solve this problem either. They don’t offer a quantized version of the flatten(); instead, they simply use torch.flatten(). QUANTIZATION API REFERENCE

from brevitas.

ScXfjiang avatar ScXfjiang commented on June 3, 2024

Hi @nickfraser @Giuseppe5,

A PR has been submitted to solve this issue. Your comments are highly appreciated, many thanks.

#941

from brevitas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.