Comments (1)
I was curious as to why this didn't happen with <strong>
tags. The following test does succeed:
it 'keeps whitespace surrounding bolds' do
result = ReverseMarkdown.convert("a\n<strong>potato</strong>\nis good\nbut blankspace is better")
expect(result).to eq "a **potato** is good but blankspace is better\n\n"
end
After some puts
debuggering, I see that this one also gets its blankspace trimmed in the first pass, but then cleaner.tidy
adds it back again in clean_tag_borders
:
converters.convert: "\n\na**potato**is good but blankspace is better\n\n"
cleaner.tidy: "a **potato** is good but blankspace is better\n\n"
So it seems that we're losing information during convert
, and assuming that **
would always be preceeded by a blankspace, which gets added in tidy
(clean_tag_borders
). The same technique wouldn't work for links, since the surrounding blankspace doesn't need to be there for markdown links.
My previous attempt of changing remove_border_lines
to use squeeze doesn't work because it would break this test:
it 'squeezes whitespace when using paragraph tags' do
result = ReverseMarkdown.convert("first paragraph\n<p>second paragraph</p>\nthird\nin separate lines")
expect(result).to eq "first paragraph\n\nsecond paragraph\n\nthird in separate lines\n\n"
end
with the following diff:
first paragraph
second paragraph
-third in separate lines
+ third in separate lines
from reverse_markdown.
Related Issues (20)
- [Question] How to change \n by </br> ?
- Process footnotes
- Hyphen(-) issue HOT 9
- HTML string containing underscores gets escaped and shown in output markdown HOT 11
- tag_border option is being ignored. HOT 3
- Blockquote not correctly closed HOT 1
- Improper space parsing within codeblock HOT 2
- Raise on character encoding errors HOT 2
- no new line char in code inside <pre> tag HOT 1
- Links to ids don't produce Markdown links HOT 3
- Github tables without a header row HOT 3
- Slack flavored Markdown HOT 6
- Unwanted new line characters within lists with paragraphs HOT 1
- Consider changing the license to something listed on Open Source Initiative list of approved licenses HOT 1
- Doesn't handle <br><br> within <strong></strong> HOT 1
- Incorrect markdown from adjacent strong tags with non-strong text after
- Incorrect markdown with non-breaking space before </i>
- Add option to convert HTML entities such as to space or unicode non-breaking space HOT 1
- Untidy tags produce invalid Markdown HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reverse_markdown.