Unrecoverable error in TUI install using all default choices about host-installer HOT 6 CLOSED

I believe this is fixed by a9a5901

from host-installer.

Right, I just stumbled on it, by diffing the source in the latest xs8 install ISO.

from host-installer.

Doesn't that makes #62 a good idea? ;)

from host-installer.

Still, I would have valued an explanation in the fix commit, explaining why this can be None (it does not even say it is protecting against None, BTW). Everywhere in the code answers['ntp-servers'] seems to be assigned an iterable value: this additional check seems to just be hiding the source of the problem rather than fixing it.

from host-installer.

Apologies, this was fixed/worked-around in a rush to meet a deadline, it was resolved in this PR https://github.com/xenserver/host-installer/pull/60/files
I've not yet had time to investigate the root cause - as observed the paths through the installer would seem to set it properly and yet the issue still occurred

from host-installer.

I've not yet had time to investigate the root cause - as observed the paths through the installer would seem to set it properly and yet the issue still occurred

Yes, as it is, it is not easy to test changes. We should really put our thoughts towards getting automated tests on this codebase.

Note I have a done some time ago a prototype that allows to manually test UI changes by running some of the code locally (told @bernhardkaindl about that). Certainly limited and not suited to running automatically - just ideas.

from host-installer.