Comments (6)
I believe this is fixed by a9a5901
from host-installer.
Right, I just stumbled on it, by diffing the source in the latest xs8 install ISO.
from host-installer.
Doesn't that makes #62 a good idea? ;)
from host-installer.
Still, I would have valued an explanation in the fix commit, explaining why this can be None (it does not even say it is protecting against None
, BTW). Everywhere in the code answers['ntp-servers']
seems to be assigned an iterable value: this additional check seems to just be hiding the source of the problem rather than fixing it.
from host-installer.
Apologies, this was fixed/worked-around in a rush to meet a deadline, it was resolved in this PR https://github.com/xenserver/host-installer/pull/60/files
I've not yet had time to investigate the root cause - as observed the paths through the installer would seem to set it properly and yet the issue still occurred
from host-installer.
I've not yet had time to investigate the root cause - as observed the paths through the installer would seem to set it properly and yet the issue still occurred
Yes, as it is, it is not easy to test changes. We should really put our thoughts towards getting automated tests on this codebase.
Note I have a done some time ago a prototype that allows to manually test UI changes by running some of the code locally (told @bernhardkaindl about that). Certainly limited and not suited to running automatically - just ideas.
from host-installer.
Related Issues (18)
- When booting to shell, the installer commandline shown to user is incomplete HOT 3
- Adding a safeguard for UEFI/legacy config switch HOT 1
- After restoring a backup, reboot is launched without notifying user to remove the install media
- Improving behaviour with pre-existing software-RAID devices HOT 6
- SR creation in need of cleanups
- VLAN configuration for `--network_(device|config)` should be reworked
- Undocumented `<admin-interface>` handling of `name` and `hwaddr` interface is confusing
- is `DebStyleInterface` code still relevant?
- UEFI Boot questions
- Read failure of a driver-source URL repo causes repo to be silently ignored
- local driver disks added by TUI are not automatically installed on host
- New release? HOT 1
- "empty" driver disk with broken groups.xml causes silent error
- Behaviour for "default NTP source" needs at least some clarifying
- 10.10.9 aborts in presence of a backup whose rootfs is on a "missing" disk
- "Back" does not work on "Virtual Machine Storage" screen, when host has a single disk HOT 2
- Proposed enhancement: allow reuse of install-time network config for installed host HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from host-installer.