Install git vs https about logger HOT 6 OPEN

Yes, https should be fine for folks who are just downloading a read-only copy of the repo. Please test that changing it to https fixes your issue, and PR if so.

from logger.

@scottleibrand thanks, will test and let you know, then hopefully PR. Likely to be next week.

from logger.

@scottleibrand sadly this didn't work and appears to be a know issue with npm install due to firewall port blocking npm/npm#6285 (comment).

The issue appears in line 10.

Observed point is immediately after upgrade-node.sh:

root@MealsDev3:~/src/Logger# sudo npm run global-install

> [email protected] global-install /root/src/Logger
> rm -rf ./node-modules/xdrip-js && ./bin/upgrade-node.sh && npm install && ./bin/logger-setup.sh

Node version already at v8 - good to go
[  ................] \ fetchMetadata: sill resolveWithNewModule [email protected] c

So I tried adding git config --global url."https://".insteadOf git:// before npm install on L10 which also didn't work.

"global-install": "rm -rf ./node-modules/xdrip-js && ./bin/upgrade-node.sh && git config --global url."https://".insteadOf git:// && npm install && ./bin/logger-setup.sh"

Any ideas if i'm missing some single quotes?

The manual work around still works https://github.com/xdrip-js/Logger#install-issues.

Thanks.

from logger.

I'm not familiar with that url insteadOf thing.

Do we need to revert anything?

from logger.

I'm not familar with it either, just tried it and it worked..

Nothing to do at the moment. Will keep thinking about it as i look as some other bits. Thanks

from logger.

Cloning into 'xerosploit'...
fatal: unable to access 'https://github.com/LionSec/xerosploit/': Could not resolve host: github.com
حد يعرف السبب

from logger.