Duration in album information screen is rendered twice about xbmc HOT 8 CLOSED

Will take a look, most likely my fault since I introduced media flags for music.

from xbmc.

@jjd-uk: After applying the changes the issue is gone completely 😃

from xbmc.

@jjd-uk maybe something you can look into?

from xbmc.

Strange but I don't see the issue on Windows, and I'm not sure why the rendering would be handled differently for this between Linux & Windows. Anyway I think I can guess at the problem even if I can't observe it for myself, and that's the flags within the nav windows are also shown within the dialog. This does not happen for me on Windows, so to get the flags shown in the music info dialog I also had to add them to the dialog, so there are added at https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/MyMusicNav.xml#L36 and https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/DialogMusicInfo.xml#L535

The simply addition of some visibility exclusions at these locations will probably fix the issue you are seeing, just need to do some testing.

from xbmc.

@neo1973 can you test if jjd-uk@4e0c87e works for you, if it does I'll PR.

from xbmc.

Thanks @jjd-uk, that fixes most of the issue. Interestingly the effect is still there during the animation when closing the album information screen. The animation during opening is fine though.

from xbmc.

@neo1973 Are you able to try changing:

https://github.com/jjd-uk/xbmc/blob/4e0c87e9ebc075e744ceb992e233b954dca4261e/addons/skin.estuary/xml/Includes.xml#L436

From <visible>Container.Content(albums) + ![Window.IsActive(songinformation) | Window.IsActive(musicinformation)]</visible>

To <visible>Container.Content(albums) + ![Window.IsVisible(songinformation) | Window.IsVisible(musicinformation)]</visible>

and

https://github.com/jjd-uk/xbmc/blob/4e0c87e9ebc075e744ceb992e233b954dca4261e/addons/skin.estuary/xml/MyMusicNav.xml#L35

From <include condition="!Skin.HasSetting(hide_mediaflags) + ![Window.IsActive(songinformation) | Window.IsActive(musicinformation)]">MediaFlags</include>

To <include condition="!Skin.HasSetting(hide_mediaflags) + ![Window.IsVisible(songinformation) | Window.IsVisible(musicinformation)]">MediaFlags</include>

I want to know if there any difference for you using IsVisible for those conditions instead of IsActive.

from xbmc.

Excellent, as thought the IsVisible takes better account of any animations.

from xbmc.