model.InsertCopy: missing step instance names inside file by using Esent about xbimessentials HOT 7 CLOSED

Hi Michael,
thanks for the question.
This sounds like a serious issue. But I've not understood the problem 100% which we need to reproduce.
Would you be able to produce a test case in Xbim.Essentials.Test?
If you do I'd add it to the solution for debugging (possibly via a pull request?)
You can add small files too, if needed, but ideally we'd like the code to be minimal to identify the offending API.
Thanks,
Claudio

from xbimessentials.

Unit test class Ifc2x3InsertCopyTest.cs to develop stream project Tests added. Note that I had include a 800KB ifc file generated from Autodesk Inventor - if the file is smaller (20KB) it works!

from xbimessentials.

I will upload once I figured out how.. 403 (Forbidden)..

from xbimessentials.

You can try pull request.

from xbimessentials.

Files uploaded to (https://github.com/xBimTeam/XbimEssentials/files/551164/Ifc2x3InsertCopyTest.zip)

from xbimessentials.

Thanks, I'll put the files in the solution soon.

from xbimessentials.

No need @CBenghi. I found a bug and it is solved now. Thank you @MichaelBuehler very much. This was a very good one to spot out. The problem was actually not related to the InsertCopy() itself but to the way transactions work in EsentModel. It keeps track of modified entities and writes them to database at the end of transaction. But once this is done we were failing to add it there again. This in your code was combined with the fact that size of transaction is limited in Esent engine so with large InsertCopy it needs to flush the changes in the meantime with the same effect. The simple testing code is this:

[TestMethod]
public void EsentMultiTransactionTest()
{
    const string file = "test.ifc";
    using (var model = EsentModel.CreateTemporaryModel(new EntityFactory()))
    {
        IfcCurtainWall wall;
        using (var txn = model.BeginTransaction("New wall"))
        {
            wall = model.Instances.New<IfcCurtainWall>(w => w.Name = "Name");
            txn.Commit();
        }
        using (var txn = model.BeginTransaction("Edit wall"))
        {
            wall.Description = "Description";
            txn.Commit();
        }
        model.SaveAs(file);
    }

    using (var model = EsentModel.CreateTemporaryModel(new EntityFactory()))
    {
        model.CreateFrom(file, null, null, true, true);
        var wall = model.Instances.FirstOrDefault<IfcCurtainWall>();
        Assert.IsTrue(wall.Name == "Name");
        Assert.IsTrue(wall.Description == "Description");
    }
}

from xbimessentials.