Comments (6)
I am currently re-writing xaionaro-go/cryptoWallet to use my fork of trezord-go as a library here
which will cause the code here to simplify a lot (I am basically removing all the intermediary classes) and improve the code here. (And I am also removing the dependency on tesoro, which is unmaintained.)
from cryptowallet.
Similarly, Ping result is not de-marshaled, as isn't Features. (I wonder how could it work for you :D )
from cryptowallet.
I see JSON unmarshaling here, which makes no sense, as JSON is not used anywhere in trezor
from cryptowallet.
Hello. I have no time on Trezors right now, so the only thing I can do is review and merge patches :(
I see JSON unmarshaling here, which makes no sense, as JSON is not used anywhere in trezor
If this's true then it's very strange. Because I remember for sure that the answer was in JSON. May be the device returns it that way or something. Or, may be it's just obsolete.
Similarly, Ping result is not de-marshaled, as isn't Features. (I wonder how could it work for you :D )
Well, it really worked, too :)
I cannot answer anything here because of no time on investigations... Sorry :(
but it's never de-marshaled from protobuf.
Yep, seems to be a mistake.
from cryptowallet.
UPD:
I've just looked into the code a little because I couldn't believe I was so careless. And it seems that actually everything is OK. The unmarshaling was done here:
https://github.com/conejoninja/tesoro/blob/master/tesoro.go#L864
And JSON messages are about there, too.
from cryptowallet.
OH OK! I looked at wrong place. In that case, closing.
(as I said, I am rewriting this library + tesoro. I will make you a PR once it's done, but basically, at that point, this library will be basically almost empty.)
from cryptowallet.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cryptowallet.