Set up continuous integration testing and coverage testing about fiasco HOT 8 CLOSED

👍 for PEP8speaks. We will definitely want to stick to PEP 8. Also tools like flake8 and pylint are good for doing those kinds of checks locally.

from fiasco.

I absolutely agree. We'll likely also want to use astropy-helpers and ci-helpers. I've setup both Travis CI builds and Coveralls for ChiantiPy so this will definitely be a top priority.

That being said, before setting up too much infrastructure (docs, CI, etc.), I'd like to decide where this repo should live. Under my personal account is probably not the best place. Perhaps under the sunpy org or maybe a new fiasco org? Thoughts on this @Cadair, @dpshelio? Ken Dere has also said we could place it under the chianti-atomic org.

from fiasco.

Good point! The SunPy org seems like a natural place to put it to me, since that would help encourage it to be part of the SunPy ecosystem. SunPy is also already a part of NumFOCUS, so it wouldn't be necessary to go through the extra work associated with creating a new organization.

from fiasco.

Good point about NumFOCUS. I hadn't thought of that. Also, starting a new org implies the need for multiple repos which I don't think will be the case (at this point anyway).

from fiasco.

With respect to the initial topic, I forgot to mention that PEP8speaks would be great to add, assuming that fiasco will use PEP 8 guidelines. I find PEP8speaks to be really helpful since I often forget to fix formatting.

from fiasco.

@wtbarnes - you could have a fiasco org without any problems, even if you have only a single repository in there. That's quite common. That could be a place where to put a website and other stuff. But again, I don't have any problem to have it under the sunpy umbrella, but since that need to be decided by a few if I would be you I would just create a fiasco organisation for now (or leave it here under your name).

from fiasco.

@dpshelio I think the best place for it to live would be under the SunPy org as CHIANTI is most often used by solar physicists and that would give it some additional exposure as people would see it when they're looking at the SunPy org.

I haven't made a big push to get it under the SunPy org yet because it has been changing quite rapidly and it was just easier to have it under my name. Also, there was some initial resistance/hesitation to adding the responsibility of maintaining an atomic physics code to the SunPy org, particularly since ChiantiPy already exists.

I think I will go ahead and add a Read the Docs page and Travis build for fiasco just under my name for now. These can always be switched later.

from fiasco.

Closing as I've now setup Travis, Read the Docs and coveralls

from fiasco.