MTNI-210 ⁃ Filter by bookmarks about memex HOT 11 CLOSED

From the nounproject website:
"The creator of each icon holds the copyright to their work. By paying for a NounPro account, you get a perpetual, non-exclusive, worldwide right to use each icon you download as many times as you wish and in any medium, without having to credit the icon’s creator. This is because Noun Project pays royalties to creators each time their icon is downloaded."

Yes, thanks for being conscious about that. I will explain the reasoning behind the change in the next meeting. In short: The public domain license is not really a license and there are legal issues with it. (https://opensource.org/node/878)

"There’s an issue though; it has not received OSI approval. Many reviewers believe it should, but its authors withdrew it from the approval process during a complex discussion about patent rights and it remains unapproved. The matter has recently been re-opened; lets hope OSI and CC can work together to bring the certainty on which open source thrives. In the mean time, it’s probably safer to use a license like MIT instead."

from memex.

So as there now is a bit more time we can still implement this:
Todos:

• Add a trigger switch to open filter options
• Add a filter for bookmarks
• Add a bookmark filter keyword to the querybuilder
• Change bookmark flag to the overview list elements
• Add a button to the overview list elements allowing a url to be bookmarked
• Prio 2: Add a button to the popup, allowing a url to be bookmarked

1. The trigger switch could look like this icon (different from mockup) and open up a whole section under the menu bar, which moves down everything else. This would leave space for later additions to the filter. (treat the transparent background as white and ignore the domain filter for now. )

2. The checkbox style for the filter is the same as in the new import process and should be named (only show bookmarks)

3. the trigger word in the query for the address bar should be isbookmark (other suggestions welcome. It seems to be something that would not appear as a word in a regular text).
   So an example query would be kitty cat in swimming pool isbookmark

4. Currently, the flag for the bookmarks is this red ribbon on the left side of the result element (as I have just seen it recently I wondered myself what it was :) ) I think it could be more clear.
   We could add a star icon on the right top side, above the trash icon, which would at the same time also function as a trigger to bookmark the url internally (without the need to bookmark it in the browser)
   This could look like this:
   Deactivated: (icon-link)

5. Make the above "Star" icon a button, that triggers a url to be bookmarked
6. Add a similar button as a new entry in the popup (first entry in the list, with state changes possible between not bookmarked (empty star) and bookmarked (filled star)

from memex.

@oliversauter as you mentioned that we have to use this icon. But this is not open source(we cannot use freely).

from memex.

I have a subscription for nounproject with the WorldBrain project.

from memex.

from memex.

@oliversauter could you add the filter icon in the repo or could you provide the icons on slack?

from memex.

@poltak I go through the deletion logic in which we are just communication with the help of WebExtensionRPC. We are sending the function name that we have to execute.
So in case of unbookmarking, we are requiring something like this to cross-script communication.

from memex.

@mukeshkharita Yes, that's right. For both bookmarking and unbookmarking in the overview, it will need remote calls.

For unbookmarking, you can reuse the function in src/bookmarks/background/deletion.js. Just needs a URL. This function needs to be made remotely callable in the background script first though (example)

The bookmark creation code in src/bookmarks/background.js should be able to be reused as well (although need to refactor it a tiny bit to decouple from the event handler).

Check out the how the overview delete works for an example of how to do the remote call from overview UI script in src/overview/actions.js (remote function set at L28).

from memex.

@poltak unbookmarking means we have to just unbookmark, we don't have to delete all the docs associated with it. It should move to the visits. right?

from memex.

@mukeshkharita Yes in most cases, but there will be cases where a page only exists with bookmark references (you bookmark a page but never visit). That function should handle both cases.

from memex.

Close this now. The only thing missing is the button in the popup, which is already underway thanks to the awsome work of @mukeshkharita.

TADA!

from memex.