Git Product home page Git Product logo

Comments (8)

fabiankaegy avatar fabiankaegy commented on June 12, 2024

I asked that question during the chat in #core-themes today and the answer was that this will become a Customizer option.

from twentynineteen.

fabiankaegy avatar fabiankaegy commented on June 12, 2024

This was the answer from @kjellr:

Blue overlay should be a setting. Still have to figure out how/where that setting is exactly though. :simple_smile:

from twentynineteen.

fabiankaegy avatar fabiankaegy commented on June 12, 2024

I would like the setting to be available in the color section inside the Customizer.

I'm also up for implementing it once @kjellr or @allancole approve that this is where this setting should go.

from twentynineteen.

fabiankaegy avatar fabiankaegy commented on June 12, 2024

Should the setting change the "primary-color" throughout the theme? i.e. Left border of pullquote, link color, button background etc.?

I think it should, but there will probably have to be some checks in order to maintain contrast ratios.

from twentynineteen.

kjellr avatar kjellr commented on June 12, 2024

The blue overlay should definitely be a setting — I'll take a look at those PRs later today.

Should the setting change the "primary-color" throughout the theme? i.e. Left border of pullquote, link color, button background etc.?

Yes, but I agree that that we should include some sort of contrast check is we do that. Because of the complexities involved in that, it should be a separate PR.

from twentynineteen.

fabiankaegy avatar fabiankaegy commented on June 12, 2024

The blue overlay should definitely be a setting — I'll take a look at those PRs later today.

Great. This one only affects the featured image overlay color

from twentynineteen.

LittleBigThing avatar LittleBigThing commented on June 12, 2024

I think that we should first consider browser compatibility of mix-blend-mode (IE and Edge) and possible fallbacks before implementing this customization. See #121 and #124.

from twentynineteen.

designsimply avatar designsimply commented on June 12, 2024

Closing this issue in favor of consolidating to #191 which is marked as a task and also has a clear unbiased title.

Feel free to keep using this issue to hash out ideas and discuss even after it is closed!

One of my goals when helping with triage is to help organize open issues to be more actionable and short when and where I can.

from twentynineteen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.