Comments (8)
I asked that question during the chat in #core-themes today and the answer was that this will become a Customizer option.
from twentynineteen.
This was the answer from @kjellr:
Blue overlay should be a setting. Still have to figure out how/where that setting is exactly though. :simple_smile:
from twentynineteen.
I would like the setting to be available in the color section inside the Customizer.
I'm also up for implementing it once @kjellr or @allancole approve that this is where this setting should go.
from twentynineteen.
Should the setting change the "primary-color" throughout the theme? i.e. Left border of pullquote, link color, button background etc.?
I think it should, but there will probably have to be some checks in order to maintain contrast ratios.
from twentynineteen.
The blue overlay should definitely be a setting — I'll take a look at those PRs later today.
Should the setting change the "primary-color" throughout the theme? i.e. Left border of pullquote, link color, button background etc.?
Yes, but I agree that that we should include some sort of contrast check is we do that. Because of the complexities involved in that, it should be a separate PR.
from twentynineteen.
The blue overlay should definitely be a setting — I'll take a look at those PRs later today.
Great. This one only affects the featured image overlay color
from twentynineteen.
I think that we should first consider browser compatibility of mix-blend-mode
(IE and Edge) and possible fallbacks before implementing this customization. See #121 and #124.
from twentynineteen.
Closing this issue in favor of consolidating to #191 which is marked as a task and also has a clear unbiased title.
Feel free to keep using this issue to hash out ideas and discuss even after it is closed!
One of my goals when helping with triage is to help organize open issues to be more actionable and short when and where I can.
from twentynineteen.
Related Issues (20)
- Video embed issues HOT 1
- Keyboard menu showing with touch menu on Mobile HOT 2
- Packagist and NPMJS HOT 1
- Editor vs. Preview/Front end alignments of blocks in columns. HOT 1
- Baskerville Old Face is a poor font choice for Windows HOT 4
- Metaboxes are overlapping the Block editor HOT 5
- Convert references to 'classic editor' and 'block editor' to proper nouns HOT 2
- Heading not aligned with the rest of the content HOT 3
- Two column block: sub-blocks not aligned in mobile view HOT 1
- No version number in doc block HOT 3
- Update version numbers for 5.0.2 release to sync with Core SVN
- .button class doesn't override link color HOT 1
- Search widget input field width is too narrow on wide screens HOT 1
- alignwide in editor causes horizontal scroll HOT 1
- Firefox Dropcap margin mismatch [Proposed Solution] HOT 2
- touch-keyboard-navigation.js conflicts with some lightboxes HOT 1
- After a word written in italic, inverted commas appear wrongly HOT 1
- Deleting all sass files HOT 2
- touch-keyboard-navigation.js breaks scrolling past links on touch HOT 2
- where are the SCSS files for the style-RTL.css HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twentynineteen.