Comments (6)
Hi,
I believe RTL styles are generated by SASS.
from twentynineteen.
Well, the rtl.css file is empty. And it is still easier to maintain when they are in the same file.
from twentynineteen.
@joyously I assume this issue can be closed now that #169 got merged, correct? With #169 the RTL CSS also gets created on the fly.
from twentynineteen.
No, it's still a question about what's the most maintainable approach.
One way you have the RTL style in the same file, following the normal CSS. It is obvious as things are changed that the RTL should be considered as well.
The other way you have the RTL style in a different file, and the developer has to remember to check if changes affect it. There is also more code to check for RTL and load the other file.
from twentynineteen.
I find the current method the best way.
There is also more code to check for RTL and load the other file.
If the site is RTL then only the style-rtl.css
will loaded not both. This is done by adding this line of code wp_style_add_data( 'twentynineteen-style', 'rtl', 'replace' );
from twentynineteen.
I'm closing this issue for now, since there are no current plans to change our RTL CSS strategy. Other default themes generally include RTL in a separate file, and @allancole clarified some of the current RTL behavior here: #257 (comment)
from twentynineteen.
Related Issues (20)
- Video embed issues HOT 1
- Keyboard menu showing with touch menu on Mobile HOT 2
- Packagist and NPMJS HOT 1
- Editor vs. Preview/Front end alignments of blocks in columns. HOT 1
- Baskerville Old Face is a poor font choice for Windows HOT 4
- Metaboxes are overlapping the Block editor HOT 5
- Convert references to 'classic editor' and 'block editor' to proper nouns HOT 2
- Heading not aligned with the rest of the content HOT 3
- Two column block: sub-blocks not aligned in mobile view HOT 1
- No version number in doc block HOT 3
- Update version numbers for 5.0.2 release to sync with Core SVN
- .button class doesn't override link color HOT 1
- Search widget input field width is too narrow on wide screens HOT 1
- alignwide in editor causes horizontal scroll HOT 1
- Firefox Dropcap margin mismatch [Proposed Solution] HOT 2
- touch-keyboard-navigation.js conflicts with some lightboxes HOT 1
- After a word written in italic, inverted commas appear wrongly HOT 1
- Deleting all sass files HOT 2
- touch-keyboard-navigation.js breaks scrolling past links on touch HOT 2
- where are the SCSS files for the style-RTL.css HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twentynineteen.