Accessibility-Ready Review and Checklist about twentynineteen HOT 11 CLOSED

If it helps, #767676 is the lightest a grey can be on white before it stops passing AA.

from twentynineteen.

Featured Images: The alt attribute for featured images is defined in the media manager. In any case where a featured image is displayed, the alt attribute must be included with the image.

In function twentynineteen_post_thumbnail, the user set alt text is replaced with the_title_attribute.
It must respect the user setting.

from twentynineteen.

Also, a question about the contrast; there are still some blocks and parts of blocks in Gutenberg where the text color has a contrast that is too low. Should the theme include a fix for this? Or do we wait and hope it is fixed in Gutenberg in time.

from twentynineteen.

Also, a question about the contrast; there are still some blocks and parts of blocks in Gutenberg where the text color has a contrast that is too low. Should the theme include a fix for this? Or do we wait and hope it is fixed in Gutenberg in time.

I think it depends — if it's on the front end, we should absolutely fix it. For issues within the editor, we'll need to evaluate on a case-by-case basis. Some things may be fixed by Gutenberg, but many issues can (and should) be solved by our editor styles. In general, if you see these issues, please go ahead and file bugs for them. 👍

from twentynineteen.

@davidakennedy I could not reproduce the first "Keyboard Navigation" issue, as I don't see any .hover state on .comment anymore.

It also seems that there is no possibility to change the focus style of the browsers <audio> tags in all browers. Firefox even lacks proper support of focussing the individual controls alltogether :/

Are there any particular issues you see with the focus on media tags? I could see a focus outline around the tags in Chrome, Firefox, IE 11 and Edge (IE 11 and Edge both actually lets you focus every individual control, at least on Windows 10).

from twentynineteen.

@davidakennedy I've also checked the other two open issues. It looks like the role attribute on the top menu was removed and I also couldn't find links in the content (and comments) without an underline style.

from twentynineteen.

It looks like the role attribute on the top menu was removed and I also couldn't find links in the content (and comments) without an underline style.

Thanks, @2ndkauboy — I can confirm these and have marked them off on the list.

from twentynineteen.

The comment

, .comment:hover, has a :hover style. However, because it's an

and not something that can receive focus, like a link, form field or button, a user can ever make the edit

I could not reproduce the first "Keyboard Navigation" issue, as I don't see any .hover state on .comment anymore.

That's right, this was addressed in #466.

The focus styles on posts navigation are not showing up properly: https://cloudup.com/cdp57bMMqiP

I believe this was addressed in #321:

I've crossed both of those off the list as well. I think the only remaining item is the one about the audio block.

from twentynineteen.

Unfortunately I don't understand the issue with the audio tag. The possibility to focus individual controls is very different from browser to browser (or OS). But im general, the audio tag can be focused and the play action can be triggered.

from twentynineteen.

Unfortunately I don't understand the issue with the audio tag. The possibility to focus individual controls is very different from browser to browser (or OS). But im general, the audio tag can be focused and the play action can be triggered.

That's my thought too — I'm able to tab through and play/pause the controller in Chrome:

... but I'm unable to do so in Firefox for instance. Since this relies on the native browser audio component, I'm not sure there's anything we can do about that.

from twentynineteen.

Set focus styles for the audio embed block: https://cloudup.com/caSR44Mg2IA

Since this appears to be an issue with how Browsers deal with the audio tag, the problem is not a caused by the theme.

Closing this since all other items have been addressed :-)

from twentynineteen.