Comments (8)
Good catch! My gut says to remove theme support for both of those (for now at least) and keep the focus purely on Gutenberg-related elements, but I'm interested in what everyone else thinks.
from gutenberg-starter-theme.
I'd say having featured image support is important for post archives, though for the actual singular post view - not so much. Gutenberg should be handling the entire presentation of the singular post view.
from gutenberg-starter-theme.
Agreed with Rich that it is helpful for archives but shouldn't be in single templates.
from gutenberg-starter-theme.
This is slightly unrelated but the same is true for custom header image. I don't think it's used on the frontend, just the custom logo. But theme does support it.
from gutenberg-starter-theme.
The main issue that comes to mind ( with removing the featured image ) is losing it when displaying post archives, in search, category and taxonomy displays. But, I just found this theme a couple of weeks ago and do not know the overall goals for the theme.
from gutenberg-starter-theme.
One of the first things I did when testing this theme was to add featured images, so the fact that they're supported was nice. That said, I love that they're not displaying by default and that the focus is on Gutenberg-related elements.
My instinct is that if you stray from pure Gutenberg elements with anything additional, featured images is the natural addition. If it potentially opens up a can of worms with people requesting other non-Gutenberg items, then bin the featured images and go pure-Gut.
from gutenberg-starter-theme.
How can I get featured images to work then? Or to display rather.
from gutenberg-starter-theme.
That seems like a reasonable compromise to me. I'll get a PR going next week, unless someone else beats me to it. 👍
from gutenberg-starter-theme.
Related Issues (20)
- not identical backend/frontend HOT 1
- Adobe Accessible Mega Menu
- Modernize the dev workflow
- Site Editor question HOT 2
- Gutenberg Demo broken HOT 3
- h5 and h6 span full width HOT 2
- Enqueue /css/blocks.css with enqueue_block_assets? HOT 2
- Alignment of images left or right next to text blocks HOT 2
- Demo broken HOT 2
- Resized image Does not display HOT 3
- Search and 404 needs styling HOT 3
- Block color palette names should be translatable HOT 1
- Add contextual color classes for editor color palette colors HOT 1
- Wrong condition in header.php for `site-title` HOT 3
- Element "Read more" has no max-width applied, as not displayed as block-element
- Not an issue, just an inquiry about Sass functionality? HOT 1
- browser upscaling
- readme.txt inaccurate
- Newbie question HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gutenberg-starter-theme.