Comments (4)
@juanmaguitar greetings! I was doing some investigating about the differences in code here, there's two main differences between it and @ryanwelcher's code.
The links on the post above are broken, probably because the test site has been merged into production. But here are the corrected links:
- Plugin Sidebar, How To guide on DevHub
- plugin-sidebar-9ee4a6 example on the
block-development-examples
repo
Observations
- On the How To guide, the code is Vanilla JS (no build step required), whereas the
block-development-examples
plugin sidebar repo code example requires NPM and a build process - The code on the How To guide was written in 2021, which is quite a bit ago. Most noticably they are passing in the
wp
andreact
objects as parameters, I'm not sure if this is necessary with the way Gutenberg works today
Relevant PR with How To guide code
Possible fix: Add the no-build example to this repo
That said, it could be possible to add the example code from the field guide to the block-development-examples
repo as a similar example with no build..
Caveat(s)
The only thing is, the code is very different, so I'm not sure if this would be more confusing. Also it's possible the code on the How To guide is out of date.
Please let me know what you all think!
Best/Seth
from block-development-examples.
Hi @flexseth, thanks a lot for the detailed report on this issue.
I'm currently on leave but will be back to work on April 1st.
Once I'm back, I'll have a look at this issue taking your comments into account, and will add a comment to this issue with my thoughts.
Cheers!
from block-development-examples.
@ryanwelcher - do you mind assigning this to me so I can more easily search it when looking for issues to work on, please! TYIA
from block-development-examples.
@juanmaguitar Hope your holiday was great!
I think I misunderstood what you were requesting!
If this is the case, I'd be happy to update the docs to reflect @ryanwelcher's code.
Thanks for taking a look!
from block-development-examples.
Related Issues (20)
- Simple editor button example (no build) HOT 2
- Using one instance of wp-scripts to work with all blocks HOT 3
- Interactivity API - Countdown Block - broken w/out Gutenberg plugin active HOT 1
- Create an example of using Block context
- Remove Experimental tag from examples using the Interactivity API HOT 1
- meta-block-bb1e55: Improve example
- Improve the readability of the "Conventions for examples" wiki page HOT 3
- Update conventions diagram to reflect the new name for this repository HOT 1
- format-api-f14b86: Document how and where the icon is being imported HOT 3
- Add creation-date, last-updated and author to the main table with examples
- Add examples for transforms
- Review `wp-scripts` package dependency on each example HOT 1
- [Proposal] — Include licenses in software packages HOT 5
- Create an example of an HOC enhancing a Core Component HOT 2
- Replace importFile with importWxr on blueprint steps HOT 1
- Fix issue with variable number of posts on every WP release HOT 1
- Adapt interactivity-api-quiz-1835fa to latest iAPI and add it to table HOT 1
- Add editable-block-no-build example HOT 2
- Add an example of enhancing a Core Component using a Higher Order Component HOT 2
- Improve example inner-blocks-dcd824
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from block-development-examples.