composer run lint is failing about block-development-examples HOT 6 CLOSED

@juanmaguitar this should be fixed now. I am basically bypassing the linting steps on the deploy branch merge.

from block-development-examples.

@juanmaguitar can we just remove the linting step from this branch/workflow? Any code that gets to this point will already have been linted. Perhaps I can adjust the action to ignore this branch.

from block-development-examples.

#70

from block-development-examples.

@ryanwelcher this is still not working properly
composer run lint fails both locally and in the GitHub Action.
I have removed "*.php": [ "composer run lint"] again from lint-staged until this issue is solved.

Note: I wouldn't consider this a high priority for now, but something to try to get fixed before the end of the year.

from block-development-examples.

@juanmaguitar if there are failures locally then my guess is that it's due to actual linting issues.

I just ran composer run lint on trunk locally and got the following error:

FILE: ...enberg-examples-2023/plugins/block-dynamic-rendering-64756b/src/render.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 11 | ERROR | All output should be run through an escaping function (see the
    |       | Security sections in the WordPress Developer Handbooks), found
    |       | 'get_block_wrapper_attributes'.
----------------------------------------------------------------------

This is correct and expected. My guess is that it was introduced with this commit. Specifically with the remove of the // phpcs:ignore comment.

from block-development-examples.

Solved as per #73

from block-development-examples.