Comments (3)
duk3luk3
commented on August 28, 2024
Is this the right approach to fix this? duk3luk3@3f6ea89
from kitsu.
wopian
commented on August 28, 2024
Not quite. Will need to handle objects and arrays separately, since that check will only verify the first item in the array is valid and the contents of the if block will fail with arrays.
from kitsu.
duk3luk3
commented on August 28, 2024
OK, I've backed out that commit and just added a spec for now so I can make sure I understand fully what needs to be changed (This is my first real JSONAPI rodeo).
I made a PR so I can run the tests without setting them up myself.
Please let me know if the spec needs fixing. It fails as expected in the appveyor build: https://ci.appveyor.com/project/wopian/kitsu/build/519/job/h8rp731s63chvols
from kitsu.
Related Issues (20)
- Error: Request failed with status code 404 HOT 1
- kitsu module not found HOT 3
- return the headers with GET respose HOT 2
- JSDoc comment for `deserialise()` is inconsistent with implementation HOT 6
- Nested same relationships does not deserialize as expected HOT 9
- [object Object] is not an Option Object when defining query parameters in Vue setup context HOT 6
- Serializing an object with a relationship is not JSONAPI compliant HOT 3
- Additional axios config options in the config for all operations
- Object type checking might fail in nuxt applications HOT 5
- Dependency Dashboard
- Documentation update & Broken for relationships HOT 3
- Issue in Deserialize function: `meta` object is getting overwritten if the same reference is used multiple places. HOT 1
- Cannot call create without attributes HOT 2
- Character api HOT 1
- Deserialise method misses meta (meta: undefined) in case of relationships with links and data HOT 1
- Question: how to detect relationships HOT 4
- Sunsetting Node 14 and 16 support HOT 5
- Adding a custom scrollbar to the webpage HOT 2
- Feature: Scroll to top HOT 3
- Issue with types HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kitsu.