Git Product home page Git Product logo

Comments (3)

pustekuchen91 avatar pustekuchen91 commented on June 8, 2024

PickupDelivery seems to come from an plugin
https://plugins.trac.wordpress.org/browser/woocommerce-germanized/trunk/packages/woocommerce-germanized-shipments/src/PickupDelivery.php#L378

wc_get_dimension is called with invalid parameter

from woocommerce.

jonathansadowski avatar jonathansadowski commented on June 8, 2024

Hi @pustekuchen91,

Thanks for the report. As you've pointed out, the underlying issue appears to be in a 3rd party plugin, and should probably be reported to its authors. The function wc_get_dimension is documented as accepting int or float for its first parameter.

I'm going to mark this issue as an enhancement request and assign it to our developers to get their opinion on whether we should be more lenient with the dimension parameter, but the bug seems to be coming from Germanized.

from woocommerce.

vedanshujain avatar vedanshujain commented on June 8, 2024

I think we can probably cast the $dimension param to float if it's not float already https://github.com/woocommerce/woocommerce/blob/007a4238c3956e3de3c33a95b3138093c1[…]1c01c7/plugins/woocommerce/includes/wc-formatting-functions.php

from woocommerce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.