Comments (3)
PickupDelivery seems to come from an plugin
https://plugins.trac.wordpress.org/browser/woocommerce-germanized/trunk/packages/woocommerce-germanized-shipments/src/PickupDelivery.php#L378
wc_get_dimension
is called with invalid parameter
from woocommerce.
Hi @pustekuchen91,
Thanks for the report. As you've pointed out, the underlying issue appears to be in a 3rd party plugin, and should probably be reported to its authors. The function wc_get_dimension
is documented as accepting int or float for its first parameter.
I'm going to mark this issue as an enhancement request and assign it to our developers to get their opinion on whether we should be more lenient with the dimension parameter, but the bug seems to be coming from Germanized.
from woocommerce.
I think we can probably cast the $dimension
param to float if it's not float already https://github.com/woocommerce/woocommerce/blob/007a4238c3956e3de3c33a95b3138093c1[…]1c01c7/plugins/woocommerce/includes/wc-formatting-functions.php
from woocommerce.
Related Issues (20)
- Introduce a new ExPlat experiment in 9.0
- Product Block Editor: clear button of attribute row doesn't show completely
- Product Block Editor: weird caret position of attributes values component
- Product Block Editor: the attribute values component loses the `box` style HOT 1
- Local Pickup instance id not being copied to order HOT 1
- Blocks E2E: Update documentation
- [Flaky] shopper/checkout.spec.js HOT 3
- [Flaky] shopper/my-account-addresses.spec.js HOT 2
- /store/v1/cart/add-item not reflected on Cart Page HOT 12
- [Enhancement]: Add Navigation Landmarks
- Failed to load resource: coming-soon.css 404
- [HPOS] CustomMetaDataStore::get_meta_keys causing EXTREMELY slow query HOT 1
- [Enhancement]: CLI command to enable sync mode without changing authoritative tables
- Removed HOT 1
- Test for 46153
- Test 2 for 46153
- [Enhancement]: logger don't write to file if message empty HOT 5
- Add MenuGroup support within `VariationQuickUpdateMenuItem`
- Bubble up errors in Store API for debug mode
- Fatal error -> HttpClientException
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from woocommerce.