Git Product home page Git Product logo

Comments (6)

tylernotfound avatar tylernotfound commented on August 15, 2024

This is too generic to hold any weight. Many others have suggested the same thing, in the same way.

Think about how this affects how people use the plugin, with multiple sliders, and propose a suggestion. :)

from flexslider.

janich avatar janich commented on August 15, 2024

I know.
I edited this issue several times after posting (to put some examples in), but figured it were easier by examples.

Here goes some specific classnames:

  • disabled
  • no-js
  • next
  • prev
  • slides

Specific other suggestions:

  • By principle (and to avoid most conflicts), prefix all css classnames (fx. flex-slides, flex-next)
  • Set fixed background-color and other most used styles on links, to avoid any template conflicts (fx. next/prev)
  • Use !important statements for the important statements (fx. list-style)
  • Use js variables for classnames in flexslider.js (makes it much easier for adoption into other templates)
  • less inline styles in flexslider.js (more css classes)

I had a blast debugging the code when I converted it to a Joomla module. Some of these I fixed, but only just the ones to keep it running in single and multiple instances. :-)

from flexslider.

tylernotfound avatar tylernotfound commented on August 15, 2024

I like the ideas you're presenting. The issue will be balancing changes to the plugin without disrupting current implementations.

from flexslider.

scubajunk avatar scubajunk commented on August 15, 2024

I would like to use the flexslider inside the Joomla framework, and there is a div with an id in the template that is overriding the flexslider styling... Janich do you have any pointers?

from flexslider.

tylernotfound avatar tylernotfound commented on August 15, 2024

Clean up your FlexSlider CSS to make those styles more important. Use deeper selectors or !important (if absolutely necessary).

from flexslider.

tylernotfound avatar tylernotfound commented on August 15, 2024

FlexSlider 2 has a special treat for class namespacing mentioned here. Closing this issue.

from flexslider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.