I'm trying to use wolfBoot on QEMU virt machine model for RISC-V. When updating fi

This should be fixed now via <a class="issue-link js-issue-link" data-error-text="Fail

Values of `version_field` and `type_field` are ignored by compiler optimization about wolfboot HOT 3 CLOSED

wolfssl commented on May 22, 2024

Values of `version_field` and `type_field` are ignored by compiler optimization

from wolfboot.

Comments (3)

danielinux commented on May 22, 2024 1

Hello,

Thanks for reporting this. I'm going to run a few tests to confirm and test the proposed solution.

from wolfboot.

danielinux commented on May 22, 2024 1

This should be fixed now via #251 which has been merged today. Feel free to reopen is anything does not check out.

Thanks!

--
D.

from wolfboot.

danielinux commented on May 22, 2024

I can confirm that this happens on other architectures as well.

On ARM Cortex-M I get:

000007dc <wolfBoot_get_blob_version>:
     7dc:   2300        movs    r3, #0
     7de:   b507        push    {r0, r1, r2, lr}
     7e0:   6802        ldr r2, [r0, #0]
     7e2:   9301        str r3, [sp, #4] 
     7e4:   4b05        ldr r3, [pc, #20]   ; (7fc <wolfBoot_get_blob_version+0x20>)
     7e6:   429a        cmp r2, r3
     7e8:   d104        bne.n   7f4 <wolfBoot_get_blob_version+0x18>
     7ea:   2101        movs    r1, #1
     7ec:   aa01        add r2, sp, #4
     7ee:   3008        adds    r0, #8
     7f0:   f7ff ffcc   bl  78c <wolfBoot_find_header>
     7f4:   2000        movs    r0, #0
     7f6:   b003        add sp, #12 
     7f8:   f85d fb04   ldr.w   pc, [sp], #4
     7fc:   464c4f57            ; <UNDEFINED> instruction: 0x464c4f57

Before the proposed changes, and the following afterwards:

000007e4 <wolfBoot_get_blob_version>:
     7e4:   2300        movs    r3, #0
     7e6:   b507        push    {r0, r1, r2, lr}
     7e8:   6802        ldr r2, [r0, #0]
     7ea:   9301        str r3, [sp, #4]
     7ec:   4b09        ldr r3, [pc, #36]   ; (814 <wolfBoot_get_blob_version+0x30>)
     7ee:   429a        cmp r2, r3
     7f0:   d003        beq.n   7fa <wolfBoot_get_blob_version+0x16>
     7f2:   2000        movs    r0, #0
     7f4:   b003        add sp, #12
     7f6:   f85d fb04   ldr.w   pc, [sp], #4
     7fa:   2101        movs    r1, #1
     7fc:   aa01        add r2, sp, #4
     7fe:   3008        adds    r0, #8
     800:   f7ff ffc8   bl  794 <wolfBoot_find_header>
     804:   2800        cmp r0, #0
     806:   d0f4        beq.n   7f2 <wolfBoot_get_blob_version+0xe>
     808:   9b01        ldr r3, [sp, #4]
     80a:   2b00        cmp r3, #0
     80c:   d0f1        beq.n   7f2 <wolfBoot_get_blob_version+0xe>
     80e:   9b01        ldr r3, [sp, #4]
     810:   6818        ldr r0, [r3, #0]
     812:   e7ef        b.n 7f4 <wolfBoot_get_blob_version+0x10>
     814:   464c4f57            ; <UNDEFINED> instruction: 0x464c4f57

from wolfboot.

Recommend Projects