Comments (3)
wnr
commented on July 3, 2024
Hi,
I'm not opposed to this change. However, it seems like you are using this library in a suboptimal way. In order to get any of the performance improvements that are unique to this library, the elements need to share the same instance of ERD. Some prefer to create a global instance, and others prefer to dependency inject the instance to the components.
from element-resize-detector.
gejgalis
commented on July 3, 2024
You're right - every time where we need detector we create new instance of erd. Now I switched in our codebase to share common instance and it works perfect!
@wnr you may drop my pull request if you want.
from element-resize-detector.
wnr
commented on July 3, 2024
Cool :)
from element-resize-detector.
Related Issues (20)
- [Question] Is V2 still planned? HOT 1
- ADA compliance issue: <object/> element is swipe-able HOT 5
- Resize detector pollutes the dom HOT 1
- erd.listenTo() always fires initially? HOT 4
- Resize not reported for particular case where listener element is in flex layout HOT 1
- 'window' is not defined in SSR
- use ResizeObserver API when available HOT 3
- Scrollbars go out of sync when using animation HOT 1
- npm show element-resize-detector versions HOT 1
- Invalid arguments. Must be a DOM element or a collection of DOM elements HOT 4
- Console warning violations in Chrome `Forced reflow while executing JavaScript` HOT 3
- [Feature Request] Provide an ECMAScript module (ESM) bundle HOT 2
- Scroll detection strategy does not work within a shadow root HOT 3
- Options are not described in README. HOT 1
- how to trigger function in start and end? HOT 1
- Do you support ie11？ HOT 1
- I want to ask what problems will occur if the code here is deleted HOT 1
- how to init not fire HOT 1
- TypeError Cannot read properties of null (reading 'defaultView') HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from element-resize-detector.