Comments (9)
Would you consider using tslint-config-prettier? I'd be willing to submit the PR if no one else is already working on it.
from create-react-app-typescript.
@LucienLee: Enforcing this was not the intention of this change. Before it, the TSLint config contained a lot of rules related to opinionated code style, like ' vs ", of stuff about whitespacing. Some of these rules are also enabled by default when using one of the TSLint standard configurations.
The intention was to kick style related rules from the config, e.g. for using tools like prettier
to format the code automatically. And that config package does a good job for achieving this.
from create-react-app-typescript.
I will accept a PR to implement this 👍
from create-react-app-typescript.
@corydeppen I don't believe anyone is working on this. Very happy to accept a PR 😄
from create-react-app-typescript.
It might be good to include this in the work @timjacobi is doing related to #109. Thoughts?
from create-react-app-typescript.
Sounds good, check #112
from create-react-app-typescript.
@wmonk I think this can be closed now 🙂
from create-react-app-typescript.
Thanks!
from create-react-app-typescript.
Hi, #281 included tslint-config-prettier, which turns off conflict tslint rule with prettier. However, that doesn't enable prettier code style. If we want to use prettier code style, we have to include tslint-plugin-prettier.
@wmonk how do you think? I can make PR for this.
from create-react-app-typescript.
Related Issues (20)
- Browserlist error
- CRA 2.0 HOT 31
- Include nodejs v8 for for Travis CI build
- Remove dependency on babel HOT 2
- Using jest-extended? HOT 1
- Husky hooks not working HOT 1
- Update webpack-dev-server HOT 10
- Add documentation detailing differences between CRA 2.0 and CRA-TS HOT 10
- Source Maps don't work for `js` or `jsx` files in live dev mode.
- Version 4.0.8: Internet Explorer no working anymore HOT 2
- Build process is almost 20 minutes long HOT 1
- postcss support? HOT 1
- Why is Jest's version hard coded to "20.0.4"? HOT 1
- Jest doesn't work when I add lint-staged
- Maintenance
- Tslint rules are barriers to entry HOT 2
- [Help] Compatibility IE + Firefox old versions problems
- Are 4.X.X versions are legit? HOT 1
- Jest doesn't resolve absolute paths from tsconfig HOT 1
- npm start dont work on freeBSD
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-react-app-typescript.