Replace style-rules in tslint with prettier about create-react-app-typescript HOT 9 CLOSED

Would you consider using tslint-config-prettier? I'd be willing to submit the PR if no one else is already working on it.

from create-react-app-typescript.

@LucienLee: Enforcing this was not the intention of this change. Before it, the TSLint config contained a lot of rules related to opinionated code style, like ' vs ", of stuff about whitespacing. Some of these rules are also enabled by default when using one of the TSLint standard configurations.
The intention was to kick style related rules from the config, e.g. for using tools like prettier to format the code automatically. And that config package does a good job for achieving this.

from create-react-app-typescript.

I will accept a PR to implement this 👍

from create-react-app-typescript.

@corydeppen I don't believe anyone is working on this. Very happy to accept a PR 😄

from create-react-app-typescript.

It might be good to include this in the work @timjacobi is doing related to #109. Thoughts?

from create-react-app-typescript.

Sounds good, check #112

from create-react-app-typescript.

@wmonk I think this can be closed now 🙂

from create-react-app-typescript.

Thanks!

from create-react-app-typescript.

Hi, #281 included tslint-config-prettier, which turns off conflict tslint rule with prettier. However, that doesn't enable prettier code style. If we want to use prettier code style, we have to include tslint-plugin-prettier.

@wmonk how do you think? I can make PR for this.

from create-react-app-typescript.