Git Product home page Git Product logo

Comments (5)

tjchaplin avatar tjchaplin commented on June 24, 2024

The pull request has updated tests, and should properly handle streams now.

Would this be ok to merge in? Do you want to discuss further?

from gulp-csvtojson.

wizicer avatar wizicer commented on June 24, 2024

Wonderful work, you almost rewrite the whole code base, I'll look into it ASAP.

BTW: I just observed one unit test failed in your PR.

from gulp-csvtojson.

tjchaplin avatar tjchaplin commented on June 24, 2024

Please let me know. All unit tests passed on my side. I have also upgraded the packages, so make sure to do an npm install before npm test.

from gulp-csvtojson.

wizicer avatar wizicer commented on June 24, 2024

Finally, I changed replace(/\s\n/g,'') to replace(/\s?\n/g,'') to make it work, my test bed is linux which only generate \n.

from gulp-csvtojson.

wizicer avatar wizicer commented on June 24, 2024

code merged, so close this issue.

from gulp-csvtojson.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.