Why is (isLeaf) function called on every single node in the tree when a node is selected? about angular-tree-control HOT 3 OPEN

That's the way angular works - it will cycle by all the methods and properties used in a template on every digest cycle. As clicking on a node will cause a digest cycle to run, the isLeaf (among other methods) will be called a few times.

Does that cause a problem for you? If so, let me know and we can see how to resolve it.

from angular-tree-control.

I'm still in an early development phase so I don't know if this will be a performance problem once the tree starts getting bigger. Thought I'd throw this one in, just in case.

from angular-tree-control.

It does seem like a potential problem for me. I have yet to look into it more, but with a tree of 5600 (56 * 10 * 10), it behaves as follows:

1. Reload the page, tree is built fast, expand/collapse works fast
2. Select a node label
3. Expand/collapse as well as everything else (e.g. entering text to input fields) has a serious delay.

PS I did verify that typing in the inputfield does trigger the isLeaf call per node.

PPS I realized that clicking on node head did not cause the "slowdown", only clicking on the label. I then tried to replace the $scope.selectNodeLabel() contents with the bare minimum I needed, e.g.

if (selectedNode.type == "MY_ROOT_TYPE") {
    this.selectNodeHead();
} else {
    $scope.onSelection({node: selectedNode, selected: true});
}

and that seems to avoid the digest cycle. There's no highlighting of the selected element but I can live with that for the moment.

from angular-tree-control.