Suggestion: Allow loginConfirmed and loginCancelled from broadcasted event about angular-http-auth HOT 9 OPEN

+1

from angular-http-auth.

This looks nice, I wish I did not consider it earlier. But now, what can I do? Should I break the API compatibility and force every one to update theirs code? Maybe once AngularJS 2.0 arrives, the new version of this module could apply this pattern, I like it.

from angular-http-auth.

Introducing a new major version doesn't force others to update to it

from angular-http-auth.

Yes, but I don't feel this one little convenience is enough to release a new major version.

from angular-http-auth.

I can still provide a pull request if you are interested in releasing a new version.

Another approach would be to create a second event; it bloats the code but won't break existing implementations.

What do you think?

from angular-http-auth.

Pull request does not hurt :) You can open one, I won't pull it now, but I will keep an eye on it, so when new major version would be prepared, I could merge it.

from angular-http-auth.

With the breaking change or the new event? Even though I prefer the breaking change, it's up to you.

from angular-http-auth.

Braking change I guess, no need to keep them both...

from angular-http-auth.

I just made available a pull request for this (#70). I think it needs a peer review, otherwise feel free to pull if you're happy with it!

from angular-http-auth.