Comments (4)
I am actually aware of the problems with theme change. To apply only light & dark theme easy, but the way the black theme was applied was not a great way. I will have to change the theme change method.
from bhagavadgitaapp.
I have fixed light, dark and black theme modes on your app. I removed the change theme function to be invoked from radio button clicks to the positive button click of the dialog box (dialog fragment). But there are minute errors that I am able to see - the option menu items are not recreated and retain their previous mode's color, meaning let's say you have switched from light to black mode, when the app was in light mode, the menu items color was black, not it should have changed to white, right? But that doesn't happen. Weird behaviour... will have to dig deep into it to find out why that happens.
I'll create a PR once I am convinced with my solution :) Hope that will be accepted by you.
from bhagavadgitaapp.
Your shared preferences tags are cluttered... Have you tried making a single class holding all the sharedpref tags in one place? That way, you'll get the exact string you need to get their values and it'll be more organised. I am trying to correct the way black, light and dark themes were implemented. Let me see what works well.
from bhagavadgitaapp.
Your shared preferences tags are cluttered... Have you tried making a single class holding all the sharedpref tags in one place?
I have not tried only thought about it later (like- If I can manage time maybe I will do it 🙂)
That way, you'll get the exact string you need to get their values and it'll be more organised.
Yeah, that's true.
I am trying to correct the way black, light and dark themes were implemented. Let me see what works well.
👍
from bhagavadgitaapp.
Related Issues (11)
- Unnecessary duplication of strings.xml HOT 3
- Unexpected Abouts Screen pops-up upon changing the theme HOT 2
- App-wide search feature request
- [feature request] Material you theme HOT 2
- [FR] Clickable random verses
- Verse 48 translates opens Verse 1. HOT 9
- Play Whole Chapter HOT 2
- [FR] Haptic Feedback
- F-Droid build failed HOT 4
- Font size increase and text copying capability HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bhagavadgitaapp.