Git Product home page Git Product logo

Comments (6)

Byrth avatar Byrth commented on July 30, 2024

So we need to wrap this in Lua's version of a try-catch block or something?

from lua.

lili-ffxi avatar lili-ffxi commented on July 30, 2024

I honestly have no idea, the function is already pcalled but the failure still stops the rest of the script from continuing to load the new file. We had a very brief conversation with Arcon about it on discord, but it didn't lead to any conclusion.

It's also possible that it's not solvable and it just goes in the "known issue" bin for when somebody comes asking across the issues and asks for support.

from lua.

Byrth avatar Byrth commented on July 30, 2024

This looks like the problem to me:

if not bool then error('\nGearSwap has detected an error in the user function '..str..':\n'..err) end

user_pcall rethrows the error instead of eating it.

from lua.

lili-ffxi avatar lili-ffxi commented on July 30, 2024

Rright, I thought that was calling logger's error function but I see error() is in fact being re-un-defined earlier.
Would a simple print() be appropriate here in this case?

from lua.

Byrth avatar Byrth commented on July 30, 2024

I think I rely on that ending code execution and I'm not sure changing it at this point is worth the risk. I'll just add a bool that explicitly converts it to print.

from lua.

Byrth avatar Byrth commented on July 30, 2024

#2315

Closed by this!

from lua.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.