Compatibility with ruby 1.8.5: "rake make" might fail because of `RbConfig::MAKEFILE_CONFIG['DEFS'] += ' -DWATCHMAN_BUILD'` about command-t HOT 4 CLOSED

Thanks for the report. I'll go ahead and workaround the lack of RUBY_PATCHLEVEL on 1.8.5. The oldest install I have access to is 1.8.6, but there is a pending pull request with a suggested workaround for the lack of #chars on 1.8.5, so we can try that, even though I can't personally test it.

from command-t.

@wincent
Great. I'd be happy to test it!

from command-t.

@blueyed: so the "next" branch now has a few fixes:

• 14fb52d works around the lack of String#chars
• b11f2c7 should make us cope with missing RUBY_PATCHLEVEL
• 29a023c tries to work around the second error you report above (in extconf.rb on line 24)

Alas, I can't test these on Ruby 1.8.5, so please let me know if you have any luck with it. And if you don't and the build blows up again, please share the contents of the mkmf.log.

from command-t.

@wincent
It works.

Thanks!

from command-t.