Please don't overload the AoC servers about advent-of-code-data HOT 5 CLOSED

Looks great!

from advent-of-code-data.

Hi Eric,

Thanks for your work on AoC!

OK, I will make v0.3 memoize the puzzle inputs and persist that data to a file storage.

It's not really possible to prevent people abusing the site by calling get_data in a loop client-side, any counter-measure I put in would be easily reversed. The responsibility for rate-limiting is better handled server-side.

What I can do is prevent a new request if the time of the last request was just 5~10 seconds ago. But it would only prevent users who made stupid mistake, it's unlikely going to stop a malicious user that wants to DoS you. Let me know what you think.

Thanks and regards,
Wim

from advent-of-code-data.

I'm not trying to stop malicious users; they have substantially better ways of executing an attack than your library. I'm trying to avoid beginners (of whom there are many doing AoC) from thinking they'll be clever and stick the method in a loop without realizing the implications.

I just posted a new thread on the subreddit since I'm seeing libraries like this more frequently lately:

https://www.reddit.com/r/adventofcode/comments/5gefzc/only_you_can_prevent_ddos_attacks_on_aoc/

from advent-of-code-data.

@topaz The latest release includes client-side rate limiting on get_data (1 request per 10 seconds) and saves the inputs to disk for later re-use. Please have a look at it and let me know if it addresses all your concerns. If there are no further changes needed, you may close this issue. Cheers 🍺

from advent-of-code-data.

One more minor change: if this is going to be widely deployed in places like pypi, please set a unique user agent so this library can be identified in my logs.

from advent-of-code-data.