Comments (6)
Hey @willywos
I'll take it up
Will fix it over the weekend
from jobbyjobjob.
Thanks @neeraj-joshi01.
Let me know if you have any questions or need any clarifications.
from jobbyjobjob.
@willywos Have submitted the PR: #23
I have added the is_saved
column to job posting and have added a check to clear only unsaved jobs in the rake task rake jobby_job:clear_job_sites
from jobbyjobjob.
Hey @neeraj-joshi01 thanks for taking a look at this one. I'm unsure of this approach though. I had a couple of questions.
-
If another user saves a job, does that mean that the job is going to show up for all users even after the posting becomes older than a month because it's been flagged as saved for one user?
-
The alternative to this approach, the one I mentioned above in the additional context. What are you thoughts on doing that instead? Could add some columns to the saved jobs table and basically make a copy of it that's associated to the user. Then would just have to update the my jobs page to pull from that location instead of job postings.
Thanks
from jobbyjobjob.
@willywos Adding columns to an existing table are pretty straightforward, But I wanted to avoid duplications while saving the same job details in multiple tables
Right now, there's no check on the jobs being shown on the Dashboard to any user (The system will show up jobs (a month old) to a user if those are there in the Database)
How about going ahead with my approach and adding a check to show only jobs published in the last month to a user?
from jobbyjobjob.
@neeraj-joshi01 ok well lets try it out and see how it goes.
from jobbyjobjob.
Related Issues (12)
- Hacktoberfest 2018 HOT 15
- Update pagination to work with search items and filters HOT 3
- Update about page and readme to include people who have contributed HOT 5
- Add RSS and JSON formats HOT 2
- Fix company logos so they don't look skewed. HOT 2
- Provide a company page HOT 3
- Add ability to remove an item from the view history. HOT 3
- Update StackOverflow feed url to include remote as the location.
- Update email layout
- Add ability for users to update their profile and password HOT 2
- Update mobile view to have filters above results
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jobbyjobjob.