Git Product home page Git Product logo

Comments (7)

Wilfred avatar Wilfred commented on May 26, 2024 4

OK, I think we have consensus on changing the logic to switch-to-buffer-other-window. Both seem natural to me, and the reasons you mention (popwin, pop-up-frames) seem sufficiently compelling to change default behaviour.

I've rolled the version number: I tagged the previous commit as 0.8, and added a note in CHANGELOG.md about this change in 0.9. If this breaks anyone's workflow, let me know.

from deadgrep.

eugeneia avatar eugeneia commented on May 26, 2024 3

I think using switch-to-buffer-other-window and find-file-other-window by default is the right choice, since they respect the pop-up-frames variable and do the expected thing for folks who configured it. If the current default behaviour of clobbering windows is desired, maybe put it behind a configuration flag?

FWIW, I am not saying the current behaviour is bad, I just think using the mentioned default makes deadgrep behave more intuitive and predicable in light of the broader Emacs ecosystem (i.e., as in expecting a replacement for rgrep.)

from deadgrep.

wbolster avatar wbolster commented on May 26, 2024

changing (switch-to-buffer) to (switch-to-buffer-other-window) seems to do the right thing for me, but changing one hard-coded behaviour with another doesn't seem the right approach. ;)

from deadgrep.

Wilfred avatar Wilfred commented on May 26, 2024

Have you tried deadgrep-visit-result-other-window, which is bound to o?

from deadgrep.

wbolster avatar wbolster commented on May 26, 2024

i am aware of that command, but it's for jumping to results. i want the deadgrep buffer itself to open elsewhere.

sorry if i was not clear.

from deadgrep.

thomasf avatar thomasf commented on May 26, 2024

yeah, popwin seems to be unable to control the deadgrep window , I guess it's because what @eugeneia says. Kind of a large usability issue for me. (I solved it by matching against deadgrep-mode instead of buffer name regexp, still have to apply the switch-to-buffer-other-window change though)

from deadgrep.

wbolster avatar wbolster commented on May 26, 2024

thanks, @Wilfred. i guess this could even be made customizable since people seem to have different preferences.

from deadgrep.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.