Comments (7)
OK, I think we have consensus on changing the logic to switch-to-buffer-other-window
. Both seem natural to me, and the reasons you mention (popwin, pop-up-frames) seem sufficiently compelling to change default behaviour.
I've rolled the version number: I tagged the previous commit as 0.8, and added a note in CHANGELOG.md about this change in 0.9. If this breaks anyone's workflow, let me know.
from deadgrep.
I think using switch-to-buffer-other-window
and find-file-other-window
by default is the right choice, since they respect the pop-up-frames
variable and do the expected thing for folks who configured it. If the current default behaviour of clobbering windows is desired, maybe put it behind a configuration flag?
FWIW, I am not saying the current behaviour is bad, I just think using the mentioned default makes deadgrep
behave more intuitive and predicable in light of the broader Emacs ecosystem (i.e., as in expecting a replacement for rgrep
.)
from deadgrep.
changing (switch-to-buffer)
to (switch-to-buffer-other-window)
seems to do the right thing for me, but changing one hard-coded behaviour with another doesn't seem the right approach. ;)
from deadgrep.
Have you tried deadgrep-visit-result-other-window
, which is bound to o
?
from deadgrep.
i am aware of that command, but it's for jumping to results. i want the deadgrep buffer itself to open elsewhere.
sorry if i was not clear.
from deadgrep.
yeah, popwin seems to be unable to control the deadgrep window , I guess it's because what @eugeneia says. Kind of a large usability issue for me. (I solved it by matching against deadgrep-mode instead of buffer name regexp, still have to apply the switch-to-buffer-other-window
change though)
from deadgrep.
thanks, @Wilfred. i guess this could even be made customizable since people seem to have different preferences.
from deadgrep.
Related Issues (20)
- Jump to an existing buffer if switching directory matches an existing results buffer
- Is there a way to support archives (-z flag)?
- Jump to exact point of search term HOT 1
- push the relevant button HOT 1
- cl-no-applicable-method error HOT 4
- T, C key binding are not supported (Get Error in mini buffer: T is undefined and C is undefined) HOT 5
- Fix: Buffer name `*deadgrep search_term /directory*' is in use
- Re-use existing `*deadgrep ...*` buffer HOT 5
- How to search filename with pattern? HOT 2
- file-remote-p: Wrong type argument: stringp, (Git "~/.emacs.d/") HOT 1
- deadgrep faces not registered until first run HOT 1
- [Feature Request] optional flags with magit-like menu?
- [Question] Is the search in directory recursive? HOT 1
- Simple search don't work HOT 4
- Feature idea: ability to identify several file types HOT 1
- [Feature Request] Add keybinding to cycle File search type HOT 2
- question: how to config deadgrep's result window not using split window? HOT 1
- how to set deadgrep-executable? HOT 1
- Question: Syntax highlight (defferent mode for each file) in results HOT 2
- [Package Idea]: An extension for XREF that works like this package?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deadgrep.