Git Product home page Git Product logo

Comments (4)

mkroetzsch avatar mkroetzsch commented on June 13, 2024

I have assigned @guenthermi now since this was marked as belonging to Browse. Or is this a change that should be done in the PaginationController instead? Feel free to re-assign the task as suitable.

from sqid.

arsylum avatar arsylum commented on June 13, 2024

Actually I think I will make a wrapper directive for this as an even cleaner solution, since many of the arguments would be the same throughout the application.

@guenthermi : Please wait with adaption / implementation until the directive is ready and merged .

from sqid.

arsylum avatar arsylum commented on June 13, 2024

I merged an update to the pagination code that brings 3 new directives that can be used within the scope of a PaginationController:

  1. <table-size-selector></table-size-selector> is a widget for selecting the number of rows that should be displayed on a page. Proposed values can be selected from a dropdown or entered manually. Allowed range [3-2000]. It has a float: right; styling applied.
  2. <pagination-index-range></pagination-index-range> displays current range of result indices and number of total results. It's not very useful yet for lack of customizability.
  3. <nav pagination="$scope.pagination"></nav> is a wrapper for the uib-pagination widget, that hooks it up with the PaginationController.

Please adapt the pagination nav in browse.html to the new directive (3), so the obsolete pagination logic can be dropped. The other two are not really necessary but we might consider to include the table-size-selector uniformly in all paginations.

from sqid.

arsylum avatar arsylum commented on June 13, 2024

merged pull request

from sqid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.