Comments (2)
Hi @maks 👍🏻 thanks for opening issues and giving feedback. We recently changed the behaviour of the theme properties due to an error that occurred when switching themes.
The current behaviour is intended and was purposely implemented this way. Making the properties required would be great but i think that just forces developers of single-themed apps to specify certain themes that aren't used anyways. Defaulting to a value is especially useful if you are using Widgetbook for implementing layouts and building widgets in isolation. However, we decided against a default theme because it might confuse people 'reading' the Widgetbook since UI elements are rendered different from what they should look like.
In the end, I think it depends on what you are using Widgetbook for. Would you mind sharing what your primary use case is?
Let me know if you have concerns regarding the argumentation provided above 😊
from widgetbook.
Ah ok, yep that all does make sense. Its pretty obvious in the UI, but may also worth just adding a note in the Readme to highlight that setting a theme is required to use widgetbook.
As for my use case, I'm currently looking to use Widgetbook as a replacement for the Storyboard package, which I have been happily using for a few years now, as to me it seems Widgetbook is an evolution of it's approach, while being more feature-rich and actively developed, where Storyboard is not.
from widgetbook.
Related Issues (20)
- Enable Semantics breaks typing into the search box HOT 3
- Request to Update Twitter Logo HOT 2
- Dynamic List Knob HOT 2
- Add support for TextScaler HOT 1
- Ability to multi-select in a list knob
- Font scaling with screen utils HOT 6
- knob is not working when label contains : or } or , HOT 1
- Addons not affecting new routes pushed by tested widgets HOT 2
- Missing SafeArea on bottom HOT 2
- InspectorAddon does not work on release builds
- Get current value of knob with valueFromQueryGroup ? HOT 1
- Dynamic Knob list
- Improve Contribution Guide HOT 4
- Single-child `WidgetbookComponent` HOT 2
- Change Twitter logo to X HOT 2
- Use cases are built excessive number of times HOT 4
- Accessibility Addon HOT 4
- Inspector Addon HOT 1
- DevTools Inspector Not Working HOT 4
- Update the Twitter Logo to X HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from widgetbook.