Git Product home page Git Product logo

Comments (2)

jenshor avatar jenshor commented on May 8, 2024

Hi @maks 👍🏻 thanks for opening issues and giving feedback. We recently changed the behaviour of the theme properties due to an error that occurred when switching themes.

The current behaviour is intended and was purposely implemented this way. Making the properties required would be great but i think that just forces developers of single-themed apps to specify certain themes that aren't used anyways. Defaulting to a value is especially useful if you are using Widgetbook for implementing layouts and building widgets in isolation. However, we decided against a default theme because it might confuse people 'reading' the Widgetbook since UI elements are rendered different from what they should look like.

In the end, I think it depends on what you are using Widgetbook for. Would you mind sharing what your primary use case is?

Let me know if you have concerns regarding the argumentation provided above 😊

from widgetbook.

maks avatar maks commented on May 8, 2024

Ah ok, yep that all does make sense. Its pretty obvious in the UI, but may also worth just adding a note in the Readme to highlight that setting a theme is required to use widgetbook.

As for my use case, I'm currently looking to use Widgetbook as a replacement for the Storyboard package, which I have been happily using for a few years now, as to me it seems Widgetbook is an evolution of it's approach, while being more feature-rich and actively developed, where Storyboard is not.

from widgetbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.