Comments (6)
whymarrh
commented on June 16, 2024
A few options are enabled by default: options. Is that what you are referring to?
from metalsmith-html-minifier.
shinze
commented on June 16, 2024
It is, thank you. I just thought the default options would be the same as it is in the original html-minifier.
I had an accessibility issue with input type attribute missing.(http://www.w3.org/TR/WCAG20/#minimize-error-suggestions).
from metalsmith-html-minifier.
whymarrh
commented on June 16, 2024
That's a fair assumption though I feel that having certain options enabled is a good default. Which option caused the a11y issue? That might be something worth reporting upstream.
from metalsmith-html-minifier.
shinze
commented on June 16, 2024
I agree about having some default enabled. The problem is about removeRedundantAttributes set to true as described in the issue. The upstream is set to false apparently.
from metalsmith-html-minifier.
whymarrh
commented on June 16, 2024
I meant more that if setting that to true induces an a11y error, that might be something upstream can fix.
from metalsmith-html-minifier.
shinze
commented on June 16, 2024
I agree. I open an issue there. Thank you !
from metalsmith-html-minifier.
Related Issues (20)
- Multimatch filtering to source files HOT 3
- Getting stuck HOT 9
- Add Node.js v6 to Travis test matrix
- Upgrade html-minifier HOT 2
- Update Jest HOT 1
- Replace Node v7 with Node 8 in Travis build matrix
- Tests should assert that the callback isn't called with an error
- Remove Babel
- Doesn't minify files below root of source folder (with default options) HOT 10
- Disable base file name matching
- html-minifier as a peer dependency? HOT 9
- Require options to be an object
- Add 'next' tag to 3.x branch HOT 2
- Update html-minifier to 4.0.0 HOT 2
- Add linting and code style checks
- Update README to reference Yarn
- Update Jest
- Replace JSCS with ESLint
- Update HTMLMinifier dep to v1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metalsmith-html-minifier.