Git Product home page Git Product logo

Comments (3)

a-sully avatar a-sully commented on August 13, 2024

Only SyncAccessHandle can currently directly access the file. Some developers don't like sync APIs, so providing "exclusive-in-place" access via FileSystemWritableFileStream might look compelling from this point of view. "Abort" could only close the stream in that case indeed.

Right, "abort" would be a bit of a misnomer. But I think that's okay?

Another potential source of confusion might be that createWritable({ mode: "exclusive-in-place" }) would clear the file, since keepExistingData defaults to false. So most(?) developers using this presumably would want createWritable({ mode: "exclusive-in-place", keepExistingData: true })... but I think that's okay, too? Changing the default only for this mode seems even more likely to lead to confusion

from fs.

a-sully avatar a-sully commented on August 13, 2024

Also, curious to hear thoughts on this issue from @annevk or @szewai

from fs.

janvarga avatar janvarga commented on August 13, 2024

Right, "abort" would be a bit of a misnomer. But I think that's okay?

Yes, I think that's ok, just that the spec should probably mention that.

Another potential source of confusion might be that createWritable({ mode: "exclusive-in-place" }) would clear the file, since keepExistingData defaults to false. So most(?) developers using this presumably would want createWritable({ mode: "exclusive-in-place", keepExistingData: true })... but I think that's okay, too? Changing the default only for this mode seems even more likely to lead to confusion

Yeah, they would have to add "keepExistingData: true" too.

from fs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.