Git Product home page Git Product logo

Comments (8)

pjackson28 avatar pjackson28 commented on June 5, 2024

What you are experiencing seems like a race condition which can happen with asynchronous execution of JavaScript. Looking over the scripting and checking recent bugs that were found, a possible culprit was the execution one possible race is between the execution of the in page wet-boew-* calls (lines 800 to 811 of pe-ap.js) and the execution of the the global calls (lines 813 to 818 of pe-ap.js). Both blocks of code fire of asynchronous calls but the second block of code parses settings.js which was causing parsing errors in IE8 because of a hanging comma. What could have been happening is that the first block of code fired off the asynchronous menu bar call and then the second code block fired off the asynchronous call with the first call reaching the find() code in question at the same time as the second call reached the hanging comma. If that is the case then that would explain why it sometimes succeeds after a series of multiple refreshes as asynchronous calls are not always consistent with their execution speed (sometimes the second call could be winning the race).

This is all just a theory since I don't have pure IE8 to test with but if that is indeed the case then the recent fix to settings.js (earlier today) would resolve that issue. Could you please test with the latest code to see if removing the hanging comma from settings.js fixed the issue?

from wet-boew.

mankev avatar mankev commented on June 5, 2024

My first thoughts were of a race condition with the Ajax loading the menus, but some testing proved this to be false. I set Ajax to run synchronously, and removed that bit of code at line 93 and simply returned a string without luck. I also tried a .delay(1000).find()... without luck.

I came across that hanging comma last week, and removed it to no avail. This was before the bug that caused a failure in all the browsers. The comma error only surfaces when in compatibility mode, so I have my doubts about this being the cause. Since I updated my code with the latest I will remove it and test again. I will also try a few other things tomorrow. I think IE8 just breaks down if you throw to much code at it.

from wet-boew.

mankev avatar mankev commented on June 5, 2024

Removing the comma did not help. Its begining to look like the menu object is simply not loading or failing soon after.

from wet-boew.

pjackson28 avatar pjackson28 commented on June 5, 2024

What happens when you test on the GitHub working examples (e.g., http://wet-boew.github.com/wet-boew/demos/index-eng.html)? Do you get the same results there as you do locally? Do you only get the problem in IE8 or do you also get it in IE7? If you get it in IE7, are you testing with IE7 pure or IE8 in IE7 mode?

from wet-boew.

mankev avatar mankev commented on June 5, 2024

Not getting the expected results. Let me do some local testing, and I will get back.

from wet-boew.

mankev avatar mankev commented on June 5, 2024

Tom has downloaded the zip, and everithing works fine, but when he visits the pages on Git-hub its a no go.

from wet-boew.

pjackson28 avatar pjackson28 commented on June 5, 2024

That's because the changes haven't propagated yet from the master branch to the gh-pages branch. The gh-pages branch is what GitHub uses to publish the working examples. I won't be able to do the propagation until later tonight.

from wet-boew.

pjackson28 avatar pjackson28 commented on June 5, 2024

Fixed by #58 which was submitted and tested by @mankev.

from wet-boew.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.