Comments (12)
@muling I tried prototyping potential fixes in this JSBin page. Would you happen to be able to take a screenshot of it in iOS Safari 14 if possible? "H1 thickline" represents the pre-existing CSS, whereas test1-4 represent potential fixes.
@delisma @Garneauma Would you be on board if I were to send a PR to fix this (given that it only impacts older browsers)? I feel kind of responsible since I suggested the selector that caused it 😅.
Can I Use... claims that the bug wasn't fixed in Safari until v15.4 (released in March 2022). I think that'd technically go beyond the scope of GCWeb's supported browsers, but is still relatively recent...
from gcweb.
oh sorry for the misunderstanding. here is the screenshot.
from gcweb.
Looks like #2169 (comment) is afflicted by a border-image
rendering bug in several older browser rendering engines (WebKit, Blink and EdgeHTML).
Check out note 1 in Can I use's CSS3 Border images page's for more info. In a nutshell, using the border-image
property apparently causes affected browsers to silently-set border-style: solid;
. I was able to replicate the buggy screenshot by adding that property to the H1 in Firefox's DOM inspector.
from gcweb.
@muling can you submit a formal request to Principal Publisher? So we will be able to take a look at that compatibility issue.
Once we will receive your request, we will check our web stats to know the iOS Safari 14 should be in-scope of our browser support. In order word, it need to represent 5% or more of the all traffic on Canada.ca.
from gcweb.
Sure. I can send a request with a screenshot to principal publisher.
from gcweb.
@muling I tried prototyping potential fixes in this JSBin page. Would you happen to be able to take a screenshot of it in iOS Safari 14 if possible? "H1 thickline" represents the pre-existing CSS, whereas test1-4 represent potential fixes.
@delisma @Garneauma Would you be on board if I were to send a PR to fix this (given that it only impacts older browsers)? I feel kind of responsible since I suggested the selector that caused it 😅.
Can I Use... claims that the bug wasn't fixed in Safari until v15.4 (released in March 2022). I think that'd technically go beyond the scope of GCWeb's supported browsers, but is still relatively recent...
You cannot see the screenshot in the original ticket?
from gcweb.
You cannot see the screenshot in the original ticket?
@muling I can see your opening post's screenshots, but I don't have Safari at my disposal :(. So I'm unable to tell whether my fix attempts in this JSBin page will fix it for sure. So someone will need to verify in Safari v15.3 or lower.
from gcweb.
@muling Thanks :)! I'll try sending a PR using test4's approach later today.
from gcweb.
I found out that the CSS Gradient is not supported by Safari older than 15.4. - https://caniuse.com/css-gradients
Which means the CSS "linear-gradient" use in the border-image
is not supported.
@muling Thanks for submitting the request to Principal Publisher, we will follow up on your request over there.
from gcweb.
@duboisp Although the screenshot in #2396 (comment) shows the gradient working in all 5 examples and test4 looks perfect. So that gradient bug doesn't actually affect the thickline style in practice.
from gcweb.
Sure. I can send a request with a screenshot to principal publisher.
I've been getting errors trying to submit the request...
from gcweb.
Just sent #2415.
@duboisp Feel free to do whatever you want with it :).
from gcweb.
Related Issues (20)
- add `timedate` to the Date modified HOT 5
- Liquid Warning: Liquid syntax error: [:comparison, ">"] is not a valid expression
- Bogue - Le contrast de couleur ne fonctionne pas
- Requête - When is the Mega Menu going to go away? and How? / Comment supprimer le Mega Menu sans causer une cascade d'exceptions javascript ?
- Bug - ʻOkina character does not display properly
- Featured link stabilization
- Featured link background stabilization
- [BUG] Canada.ca Menu - aria-label exceeds 250 characters HOT 1
- Bug - missing background on web alerts
- Fieldflow
- Broken example link on GCWeb index page
- Checkboxes are not user friendly for Dragon Naturally Speaking users HOT 1
- Bogue - Message contextuel tronqué sur le bouton de fermeture (wb-overlay)
- Inconsistent documentation between English and French
- Update twitter icon to X
- Breaking Jekyll native behaviour HOT 1
- wb-fieldflow dropdown list removes destination page URL query parameters HOT 3
- Bug - Breadcrumb links are cutoff on smaller screens
- Gradient underline on H1 issue
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gcweb.