partners grid about gcweb HOT 13 CLOSED

@shawnthompson , we did not change the grid system per say we simplified it a bit to allow for better reflow. Do you since you have copied the main files to the partners file I am assuming they will benefit from this as well. Closing this since I merged the last PR you made with this change. 👍

from gcweb.

No we changed from the bootstrap grid system to the equal heights customs grids being used by the social media tables.

from gcweb.

The equal heights grid is simply a stack of equal sized boxes :) the wrapper element that contains the items is still bootstrap. I know it seems a bit of a play on words, and do not want to confuse people since in short the CSS is canned the equal-heights does the tricky parts correct?

from gcweb.

Nope, I had to use custom css in the themes file to make it behave properly. Doesn't work in the partners version because of the left navigation. I'll take a look at it tomorrow.

Shawn Thompson
[email protected]

On Nov 3, 2013, at 6:58 PM, Mario Bonito [email protected] wrote:

The equal heights grid is simply a stack of equal sized boxes :) the wrapper element that contains the items is still bootstrap. I know it seems a bit of a play on words, and do not want to confuse people since in short the CSS is canned the equal-heights does the tricky parts correct?

—
Reply to this email directly or view it on GitHub.

from gcweb.

Ok, thanks. This is not what is should be though. The equal heights plugins is really simple in terms of what it does. The magic of flowing boxes should be a simple nth-child() style scenarios in css so that it can be flexibly in any area , of the bootstrap grid. I will take a look as well since it could have gotten a bit to bloated from the sounds of it.

from gcweb.

It's because we would need to use clearfix divs after every second and third section in order to make sure the grids worked right. We don't want to do that because it creates extra code for nothing. Let's talk about it tomorrow.

from gcweb.

@shawnthompson The problem was due to the margins. You had left and right margins on all sect-lnk elements. The outside margins for each row should be zero. I PR'd a fix in #113.

from gcweb.

@masterbee @shawnthompson was trying to achieve a 1-column (<992px), 2-column (>=992px) and 3-column (>=1200px) layout and could not achieve it using the bootstrap grid. He used the CSS I used to achieve that same layout in the mobile and social media galleries.

from gcweb.

@thomasgohard, so you wanted to achieve a 1 column display at 992px? This is not the theme specification, 1 column display should only occur at <768px, 2 column <=992px and 3 column >992px.

from gcweb.

@masterbee Sorry, I think my thoughts were going faster than my typing. It's 1-column (<992px), 2-column (>=992px) and 3-column (>=1200px).

from gcweb.

@thomasgohard , sorry I think we are both thinking to fast 🌴 In short the theme specification says that on desktop ( 992px and greater ) columns should be 3, on medium view which is tablet, etc ( 768 to 991px ) columns should be 2 , and anything below 768px should be one column.

Make sense? ( that is in essence how Twitter Bootstrap is aligned with its classes )

from gcweb.

My typing can keep up with thoughts! It's GitHub that has an issue rendering. I have to escape the lesser than sign.

What it's supposed to say in my two comments above is:
1-column (<992px), 2-column (>=992px) and 3-column (>=1200px)

But you're saying it should be:
1-column (<768px), 2-column (>=768px) and 3-column (>=992px)

Is that correct?

from gcweb.

@thomasgohard - Ahh gotcha on the typing and yes that is what I am saying :)

from gcweb.