Comments (4)
jirikolarik
commented on April 28, 2024
Yes, we are uploading only remote files, but that shouldn't be problem to add this functionality
from prestashop.
tcurdt
commented on April 28, 2024
Should we just get rid of the URI check and pass it directly?
from prestashop.
jirikolarik
commented on April 28, 2024
I'd suggest to make the check more sophisticated otherwise it may fail, when the path doesn't exists.
from prestashop.
tcurdt
commented on April 28, 2024
You want to check if it's a path or a URL - and if it's a path check for existence?
I would have delegated this further down the to the underlying (MiniMagick) implementation. That should give an error we can just catch.
from prestashop.
Related Issues (12)
- Typo in gemspec (homepage url) HOT 4
- Getting associations HOT 4
- can't add manufacturer with special symbols in name HOT 1
- Add 'price' parameter conform to API documentation
- Order with multiple cart_items HOT 3
- Error using PUT command in API HOT 2
- While updating Order returns TypeError: no implicit conversion of Symbol into Integer HOT 1
- product variants? HOT 26
- Available API calls
- can't modify frozen String HOT 2
- connection not working correctly HOT 27
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prestashop.