False Positive about why-did-you-render HOT 10 CLOSED

@parties I dont have it here where I updated react-redux and redux:
https://codesandbox.io/s/whydidyourender-false-positive-demo-pjkn7

These older versions didn't handle state changes as well as the last version.
I strongly suggest using the last one.

from why-did-you-render.

it probably has to do with react-navigation indeed because i don't see any reason why it's state changes. you does't even use it.

just to make it clear, your component doesn't look like it re-renders with the same props, the state it warns about is the this.state of SyncView, not the redux state.

I didn't work with react native for a long time so i'm not sure I can help you by myself.

but lets try some things:

1. what version of react do you use?
2. what version of the library do you use?
3. can you try the same by changing props through a father and not redux?

also in your example you wrap MyComp. is it a typo? do you need to edit it to be SyncView?

from why-did-you-render.

@Aequitas737

from why-did-you-render.

@vzaidman

1. "react": "16.5.2",
2. "@welldone-software/why-did-you-render": "^2.5.2"
3. I couldn't try as it's no longer set up in the same way, but It's worked before.
   Yeah it was a typo

from why-did-you-render.

ok. so you can't reproduce it anymore?

from why-did-you-render.

As in I don't have why-did-you-render set up anymore. I only added it temporarily to test several tools to help improve performance of the app.

from why-did-you-render.

ok thanks. if you wish to try again with me you are welcome to reopen the issue.

from why-did-you-render.

@vzaidman

I am seeing this issue myself when using connect in a simple Todo app.

(I think) I have made a working demo replicating this bug; it appears to be showing a false positive about a different state object for a component that doesn't use state at all.

Demo here: https://codesandbox.io/s/1j4qc

from why-did-you-render.

Ah ha, interesting.

I had those packages set to the older versions since those are the current versions of the application I'm currently working on (large app, not a trivial upgrade).

Thank you for taking a look, @vzaidman.

from why-did-you-render.

Updating Redux fixed this issue for me

from why-did-you-render.