Brace layer naming off about work-sans HOT 8 CLOSED

Oh thank you, I had the layers named so since I had a bunch of other masters in the same file. I'll rename the layers.

from work-sans.

The reason we implemented it like that was not because we were feeling lazy, but to ensure that the generated designspace file could be rountripped back to .glyphs while keeping he original (inconsistent) brace layer names. We could do it differently (merge brace layers with same location) but then it won’t round trip back the same (which may be ok and better than failing on compile?)

from work-sans.

Fixed

from work-sans.

from work-sans.

Not quite -- you got layer names like {170,}, which the code doesn't like. Please remove the comma. Also, there is still Regular {137} next to {137}. The full layer name is important and there should be just one full layer name associated with one location, so please change every 137 layer to either {137} or Regular {137} (respectively 170).

Also, I'm seeing a layer named Regular 137, 0, was that one supposed to have braces?

Also also, g_idieresis has a single bracket layer "[229]". If you want to make use of the designspace glyph substitution thing, please add a matching brace layer for the thin and regular masters, as the glyphsLib code currently only supports changing the whole glyph.

from work-sans.

Thanks for spotting those! Fixed now. That g_idieresis is a non exporting glyph, I've fixed the name as well anyway

from work-sans.

Thanks for fixing things up, I can indeed build a VF TTF out of both files now. Is the different OS/2.usWinDescent in WorkSans-Italic intentional (322, 343, 343)?

from work-sans.

Ohhh, those values shouldn't be different...

from work-sans.