Git Product home page Git Product logo

Comments (9)

crystaltype avatar crystaltype commented on May 27, 2024 1

The .cap accents are just a tiny bit smaller than the basic accents, and the .asc are even smaller, I think using the .asc makes sense!

Absolutely!

Sorry I'm a bit confused :) I don't think they should be the stroke weight, I think they shouldn't be just scaled components since then the weight is not correct. I think they should be scaled then adjusted to match in weight with the rest of the accents. Regarding the size of the accents, let's try slightly smaller ones then to compensate.

Oh, I see, thanks! I'll try your suggestions!

So are you saying there's 2 correct ways to draw the hookabove:

When the hookabove doesn't end with a vertical down stroke, the bottom of the hookabove should not end horizontally but should end perpendicular to the stroke (like in your first suggestion)?
Have a bottom stroke like a question mark?

Yes, that's exactly what I mean. There are some variations but the most natural way should be like that.

from work-sans.

weiweihuanghuang avatar weiweihuanghuang commented on May 27, 2024 1

Hey @crystaltype how's it going :)

from work-sans.

weiweihuanghuang avatar weiweihuanghuang commented on May 27, 2024

Hi @crystaltype that sounds awesome! Would be happy for you to contribute, with some back and forth feedback and revision I'm sure we can get to a really great result!

from work-sans.

weiweihuanghuang avatar weiweihuanghuang commented on May 27, 2024

Please send me an email at [email protected]

from work-sans.

weiweihuanghuang avatar weiweihuanghuang commented on May 27, 2024

Thanks for getting the files to me, things look great so far, my feedback:

  • I have lowercase, .cap (for uppercase), .asc (for lowercase with ascender) versions of diacritics which are shorter but still in matching weight. The Vietnamese diacritics should also have corrected versions for each diacritic too.
  • hookabove: In Medium looks too light at the bottom. In Black master, it's way too light. The terminals also don't conform to the Grotesk sans style of Work Sans, please see the cedilla and ogonek and the way the stroke ending has slight flaring in the end.
  • Circumflex: I'd really prefer not to scale these to make Vietnamese diacritics, they should be the same weight and I think the same height (using either the .cap or .asc version of diacritics), and the second diacritic on top can be smaller and still matching in weight (e.g. the acute, grave, hookabove, tilde):

Current:
unnamed

Suggestion:
unnamed-1
What do you think about this? Is this too big? And metrics wise I wonder if that's ok?

from work-sans.

crystaltype avatar crystaltype commented on May 27, 2024

Thank you for your feedback!

I have lowercase, .cap (for uppercase), .asc (for lowercase with ascender) versions of diacritics which are shorter but still in matching weight. The Vietnamese diacritics should also have corrected versions for each diacritic too

I reviewed and the cap version seems not different from the regular accents. The .asc accents do fit the cap version of Vietnamese really well though. I think I'll be using them for the Vietnamese uppercases.

hookabove: In Medium looks too light at the bottom. In Black master, it's way too light. The terminals also don't conform to the Grotesk sans style of Work Sans, please see the cedilla and ogonek and the way the stroke ending has slight flaring in the end.

It's because of Vietnamese's way of writing the hookabove, it should be lighter in the bottom (for a natural look based on our habit of writing, we tend to loosen the grip towards the end of drawing it). And although it does looks like the vertical flipped cedilla/ogonek , the hookabove actually can't be composed from those two accents. The flaring ending, I think will be considered a mistake of some sort (because we don't extend the tail/bottom of the hookabove while we write). Your suggestion is also good, but the counter of the hookabove is a little small, so in the black/heavy/bold weights it might end up looks like a dot in smaller sizes.

Circumflex: I'd really prefer not to scale these to make Vietnamese diacritics, they should be the same weight and I think the same height (using either the .cap or .asc version of diacritics), and the second diacritic on top can be smaller and still matching in weight (e.g. the acute, grave, hookabove, tilde):

Yes, I think so too at first, but after having a lot of experiences working with large type family, I realized that the black/heavy weights is really problematic if we do it this way. If we keep all the caps accents to have the same weight as the stroke weight, they'll be really hard to make out at smaller sizes (smaller accents but still have bold/heavy weight - for example, the circumflex just looks like a quadrilateral or something like that, or the breve just look like a hyphen). For the most parts, the uppercases with double diacritics rarely used in Vietnamese (excepts for when we're using allcaps), so I think the best way for now is scaling the diacritics (keeping the ratio, not squeezing tho), so it won't look too rough/too big when viewing at large size, it's also can be accepted and doesn't interfere with the flow of reading in the most cases. It also helps with keeping the vertical metrics at a sane amount.

Although it might not be in sync with the whole font. Vietnamese also only used these accents that some other languages also used: acute, grave, tilde, circumflex and breve. So I think it's not necessary to keep Vietnamese looks good when standing with another language, but we should concentrate on keeping the Vietnamese looks good when standing alone (and also looks good with ONLY those [characters+acute/grave/tilde/circumflex] that other languages are using).

Actually I realise my previous example looks huge, maybe something like this where the hookabove in circumflex_hookabove is a bit smaller but visually balanced – do you think the flat bottom works?

It works in some cases, when we draw the hookabove just like we draw the question mark (?). I mean, it will look natural if the hookabove have a bottom stem like the question mark, or else it doesn't look natural at all. If we keep this shape, and with a flat bottom stem, it feels like the bottom stem has been mistakenly erased to me.

====

I'll use the .asc accents for the uppercases instead tho. Thank you for the suggestions! Please let me know what you think. When all are OK I'll begin to fix and send the file back to you :)
Thanks!

from work-sans.

weiweihuanghuang avatar weiweihuanghuang commented on May 27, 2024

Hey @crystaltype, thanks for the response!
The .cap accents are just a tiny bit smaller than the basic accents, and the .asc are even smaller, I think using the .asc makes sense!

It's because of Vietnamese's way of writing the hookabove, it should be lighter in the bottom (for a natural look based on our habit of writing, we tend to loosen the grip towards the end of drawing it). And although it does looks like the vertical flipped cedilla/ogonek , the hookabove actually can't be composed from those two accents. The flaring ending, I think will be considered a mistake of some sort (because we don't extend the tail/bottom of the hookabove while we write). Your suggestion is also good, but the counter of the hookabove is a little small, so in the black/heavy/bold weights it might end up looks like a dot in smaller sizes.

Thanks for this! Go for what you think looks best then! I'm not concerned about the Black/Heavy weights being used at smaller sizes, the whole typeface will have legibility issues at small sizes. But I do want to keep bold Legible at smaller sizes.

Yes, I think so too at first, but after having a lot of experiences working with large type family, I realized that the black/heavy weights is really problematic if we do it this way. If we keep all the caps accents to have the same weight as the stroke weight, they'll be really hard to make out at smaller sizes (smaller accents but still have bold/heavy weight - for example, the circumflex just looks like a quadrilateral or something like that, or the breve just look like a hyphen). For the most parts, the uppercases with double diacritics rarely used in Vietnamese (excepts for when we're using allcaps), so I think the best way for now is scaling the diacritics (keeping the ratio, not squeezing tho), so it won't look too rough/too big when viewing at large size, it's also can be accepted and doesn't interfere with the flow of reading in the most cases. It also helps with keeping the vertical metrics at a sane amount.

Sorry I'm a bit confused :) I don't think they should be the stroke weight, I think they shouldn't be just scaled components since then the weight is not correct. I think they should be scaled then adjusted to match in weight with the rest of the accents. Regarding the size of the accents, let's try slightly smaller ones then to compensate.

It works in some cases, when we draw the hookabove just like we draw the question mark (?). I mean, it will look natural if the hookabove have a bottom stem like the question mark, or else it doesn't look natural at all. If we keep this shape, and with a flat bottom stem, it feels like the bottom stem has been mistakenly erased to me.

So are you saying there's 2 correct ways to draw the hookabove:

  1. When the hookabove doesn't end with a vertical down stroke, the bottom of the hookabove should not end horizontally but should end perpendicular to the stroke (like in your first suggestion)?
  2. Have a bottom stroke like a question mark?

from work-sans.

dasklney avatar dasklney commented on May 27, 2024

Hope we can get the Vietnamese version of this font :D

from work-sans.

weiweihuanghuang avatar weiweihuanghuang commented on May 27, 2024

Vietnamese has been added to the latest fonts!

from work-sans.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.