Graphs are light themed about pvediscorddark HOT 14 CLOSED

@Fusl I have put your suggestion in the browser extension style. The server-sided javascript modifications can be found here.

from pvediscorddark.

Aware of it. Though its not something I can change with CSS as the graphs colors are set by js.

from pvediscorddark.

Makes sense. Just figured I'd mention it here, get the conversation started.

from pvediscorddark.

How about adding this CSS?

.x-surface-canvas {
    filter: invert(100%);
}

.x-legend-item-marker {
    filter: invert(100%);
}

Doesn't look great but it's better than being dazzled by a white graph:

from pvediscorddark.

That does look a little bit ugly but will work for now.
As for a better fix, I am currently working on editing the js files for the charts and its going well - though this is for the serverside option only.

from pvediscorddark.

This is how it looks so far, what do you think @Fusl

from pvediscorddark.

I'll chime in that personally I don't mind the ugliness. It's still much easier on the eyes compared to a white background.

from pvediscorddark.

Hm alright. I'll add it to the client-sided css soon.

from pvediscorddark.

This is how it looks so far, what do you think @Fusl

That one looks amazing. Have my vote for this for the server side option.

from pvediscorddark.

Going to add it into the repo today. Although it will only work for PVE 5.4-3 as I do not have any servers running lower and the js files might differ by a lot.

from pvediscorddark.

@Weilbyte Hey I dont believe you push those new invert CSS to the ddInstaller CSS file. Not sure if that was intentional or not.

from pvediscorddark.

@ZeroPoke intentional, the server-side version has a JavaScript bit that you can install to make the graphs dark. The inverted quick-fix is available for client-side only.

from pvediscorddark.

@Weilbyte I am using Proxmox 6 right now and it works perfectly fine as well. I think you should add an option whether to install the JSMod or not in the install script or at least make a mention of it in the README, it will help a lot of people. :D

If you change the screenshot in the README to the dark graphs it would make everything look neater as well :)

from pvediscorddark.

@Ethereal739 It is mentioned in the readme at the serverside instructions part.

If you're on 6.0 it's not recommended to run the 5.4 JSMod as it replaces files some files. Though JSMod for 6.0 (6.0-4) is going to be out tomorrow and that should replace those somewhat incompatible 5.4 ones back to the usual 6.0 ones so no worries there.

from pvediscorddark.