Reading private ele data is OK, but renderer data is not about cytoscape-css-renderer HOT 4 OPEN

Where am I reading private renderer data?

I assume you're referring to the last line of the following:

    var CanvasRenderer = $$.extension('renderer', 'canvas');
    function CssRenderer(options){
      CanvasRenderer.call(this, options);
      this.data.cssContainer = document.createElement('div');
      this.data.cssContainer.className = "cssContainer";
      this.data.cssContainer.style = $$.util.extend(this.data.cssContainer.style, {
        postion: "absolute",
        top: 0,
        right: 0,
        bottom: 0,
        left: 0
      });
      this.data.container.appendChild( this.data.cssContainer );
    }
    CssRenderer.prototype = Object.create(CanvasRenderer.prototype);
    CssRenderer.prototype.constructor = CssRenderer;
    $$.util.extend(CssRenderer, CanvasRenderer);

The CanvasRenderer class has a number of properties that are assigned prior to instantiation, is that what you're referring to?

from cytoscape-css-renderer.

Accessing the shared data object in that case may be problematic, but considering #3 this issue is probably redundant. Just wanted to make sure I wrote down all my initial thoughts so they wouldn't be lost.

from cytoscape-css-renderer.

Thank you for the feedback.

I need to push forward on the project I'm using this in, but should be revisiting the codebase soon.

from cytoscape-css-renderer.

Cool; good luck with your project.

from cytoscape-css-renderer.